DEV: Update deps, add syntax_tree (#4)

Author: CvX

.github/workflows/ci.yml

@@ -11,27 +11,33 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
 
       - name: Set up Ruby
         uses: ruby/setup-ruby@v1
         with:
-          ruby-version: '2.7'
+          ruby-version: "3.3"
           bundler-cache: true
 
       - name: Lint
         run: bundle exec rubocop
 
+      - name: syntax_tree
+        if: ${{ !cancelled() }}
+        run: |
+          set -E
+          bundle exec stree check Gemfile $(git ls-files '*.rb') $(git ls-files '*.rake') $(git ls-files '*.thor')
+
   publish:
     if: github.event_name == 'push' && github.ref == 'refs/heads/main'
     needs: build
     runs-on: ubuntu-latest
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
 
       - name: Release Gem
-        uses: discourse/publish-rubygems-action@v2
+        uses: discourse/publish-rubygems-action@v3
         env:
           RUBYGEMS_API_KEY: ${{ secrets.RUBYGEMS_API_KEY }}
           GIT_EMAIL: [email protected]

.rubocop.yml

@@ -1,2 +1,15 @@
 inherit_gem:
-  rubocop-discourse: default.yml
+  rubocop-discourse: stree-compat.yml
+
+inherit_mode:
+  merge:
+    - Exclude
+
+Discourse/NoChdir:
+  Enabled: false
+
+Discourse/Plugins/NamespaceConstants:
+  Enabled: false
+
+Discourse/Plugins/NamespaceMethods:
+  Enabled: false

.streerc

@@ -0,0 +1,2 @@
+--print-width=100
+--plugins=plugin/trailing_comma,plugin/disable_auto_ternary

discourse_dev_assets.gemspec

@@ -1,29 +1,30 @@
 # frozen_string_literal: true
 
 lib = File.expand_path("../lib", __FILE__)
-$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
+$LOAD_PATH.unshift(lib) if !$LOAD_PATH.include?(lib)
 require "discourse_dev_assets/version"
 
 Gem::Specification.new do |spec|
-  spec.name          = "discourse_dev_assets"
-  spec.version       = DiscourseDevAssets::VERSION
-  spec.authors       = ["Vinoth Kannan"]
-  spec.email         = ["[email protected]"]
+  spec.name = "discourse_dev_assets"
+  spec.version = DiscourseDevAssets::VERSION
+  spec.authors = ["Vinoth Kannan"]
+  spec.email = ["[email protected]"]
 
-  spec.summary       = %q{Assets for Discourse dev module}
-  spec.description   = %q{Assets for Discourse dev module}
-  spec.homepage      = "https://github.com/discourse/discourse_dev_assets"
-  spec.license       = "MIT"
+  spec.summary = "Assets for Discourse dev module"
+  spec.description = "Assets for Discourse dev module"
+  spec.homepage = "https://github.com/discourse/discourse_dev_assets"
+  spec.license = "MIT"
 
-  spec.files         = `git ls-files`.split($/).reject { |s| s =~ /^(spec)/ }
+  spec.files = `git ls-files`.split($/).reject { |s| s =~ /^(spec)/ }
   spec.require_paths = ["lib"]
 
-  spec.add_runtime_dependency "faker", "~> 2.16"
+  spec.add_runtime_dependency "faker", "~> 3.5.1"
   spec.add_runtime_dependency "literate_randomizer"
 
-  spec.add_development_dependency "bundler", "~> 2.0"
-  spec.add_development_dependency "rake", ">= 12.3.3"
-  spec.add_development_dependency "rubocop-discourse", "~> 2.5.0"
+  spec.add_development_dependency "bundler"
+  spec.add_development_dependency "rake"
+  spec.add_development_dependency "rubocop-discourse"
+  spec.add_development_dependency "syntax_tree"
 
-  spec.required_ruby_version = '>= 2.6.0'
+  spec.required_ruby_version = ">= 3.3.0"
 end

lib/discourse_dev_assets.rb

@@ -1,14 +1,14 @@
 # frozen_string_literal: true
 
-Dir[File.dirname(__FILE__) + '/**/*.rb'].each { |file| require file }
+Dir[File.dirname(__FILE__) + "/**/*.rb"].each { |file| require file }
 
 module DiscourseDevAssets
-  require 'discourse_dev_assets/engine'
+  require "discourse_dev_assets/engine"
 
   def self.avatars
     # Using the stock avatar images from https://tinyfac.es
     # Tiny Faces is a free crowd-sourced avatar gallery
-    Dir[File.join(__dir__, '..', 'avatars', '*.*')]
+    Dir[File.join(__dir__, "..", "avatars", "*.*")]
   end
 end
 
@@ -18,41 +18,45 @@ def self.avatars
   alias_method :rails_each_current_configuration, :each_current_configuration
 
   private
+
   def each_current_configuration(environment, name = nil)
-    rails_each_current_configuration(environment, name) { |db_config|
-      next if environment == "development" &&
-        ENV["SKIP_TEST_DATABASE"] == "1" &&
-        db_config.configuration_hash[:database] != "discourse_development"
+    rails_each_current_configuration(environment, name) do |db_config|
+      if environment == "development" && ENV["SKIP_TEST_DATABASE"] == "1" &&
+           db_config.configuration_hash[:database] != "discourse_development"
+        next
+      end
 
       yield db_config
-    }
+    end
   end
 end
 
-require 'faker'
+require "faker"
 
 Faker::Base.instance_eval do
-  alias :faker_translate :translate
+  alias faker_translate translate
 
   def translate(*args, **opts)
-    if args[0] == "faker.lorem.words"
-      args[0] = "faker.discourse.words"
-    end
+    args[0] = "faker.discourse.words" if args[0] == "faker.lorem.words"
 
     faker_translate(*args, **opts)
   end
 end
 
-require 'literate_randomizer'
+require "literate_randomizer"
 
 Faker::Lorem.instance_eval do
-  alias :faker_sentence :sentence
-  alias :faker_paragraph :paragraph
+  alias faker_sentence sentence
+  alias faker_paragraph paragraph
 
   NOT_GIVEN = Object.new
 
   def sentence(word_count: 4, supplemental: false, random_words_to_add: 15)
-    faker_sentence(word_count: word_count, supplemental: supplemental, random_words_to_add: random_words_to_add)
+    faker_sentence(
+      word_count: word_count,
+      supplemental: supplemental,
+      random_words_to_add: random_words_to_add,
+    )
   end
 
   def paragraph(options = {})

lib/discourse_dev_assets/engine.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
 module DiscourseDevAssets
-  class Engine < Rails::Engine; end
+  class Engine < Rails::Engine
+  end
 end

lib/discourse_dev_assets/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module DiscourseDevAssets
-  VERSION = "0.0.4"
+  VERSION = "0.0.5"
 end