Skip to content
This repository was archived by the owner on Mar 26, 2025. It is now read-only.

Not compatible with the most recent version of html5lib #345

Closed
Chronial opened this issue Aug 8, 2016 · 3 comments
Closed

Not compatible with the most recent version of html5lib #345

Chronial opened this issue Aug 8, 2016 · 3 comments

Comments

@Chronial
Copy link

Chronial commented Aug 8, 2016

Fails with the most recent version of html5lib (0.999999999) with this exception:

  File ".../python3.4/site-packages/djangocms_text_ckeditor/html.py", line 8, in <module>
    from html5lib import sanitizer, serializer, treebuilders, treewalkers

This is probably caused by this change (from htlm5lib changelog):

Get rid of the sanitizer package. Merge sanitizer.sanitize into the sanitizer.htmlsanitizer module and move that to saniziter. This means anyone who used sanitizer.sanitize or sanitizer.HTMLSanitizer needs no code changes.

@czpython
Copy link
Contributor

czpython commented Aug 8, 2016

Thanks for reporting.
Closing as a duplicate of #336
djangocms-text-ckeditor currently pins html5lib to be less than 0.999999999

@czpython czpython closed this as completed Aug 8, 2016
@Chronial
Copy link
Author

Chronial commented Aug 8, 2016

Ah, thx – I actually checked that, but was fooled by the requirements.txt :).

I will see if I can produce a PR for the actual issue – our project needs a more recent version of html5lib.

@czpython
Copy link
Contributor

czpython commented Aug 8, 2016

@Chronial That would be amazing :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants