Skip to content

Commit 89b29ad

Browse files
Pinned redis py to 4.3.5 (#349)
* tox tests longer than 10 minutes are likely hung so let github bail * pin redis 4.3.5 * let the async_timeout occur * Added change note. --------- Co-authored-by: Carlton Gibson <[email protected]>
1 parent ffe3566 commit 89b29ad

File tree

5 files changed

+13
-3
lines changed

5 files changed

+13
-3
lines changed

.github/workflows/tests.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ jobs:
1010
tests:
1111
name: Python ${{ matrix.python-version }}
1212
runs-on: ubuntu-latest
13+
timeout-minutes: 10
1314
strategy:
1415
fail-fast: false
1516
matrix:

CHANGELOG.txt

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,10 @@
1+
UNRELEASED
2+
----------
3+
4+
* Pinned redis-py version to 4.3.5 in order to avoid difficult to diagnose
5+
issues occurring with redis-py 4.4+ (to 4.5.2 currently).
6+
7+
18
4.0.0 (2022-10-07)
29
------------------
310

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
include_package_data=True,
3131
python_requires=">=3.7",
3232
install_requires=[
33-
"redis>=4.2.0",
33+
"redis==4.3.5",
3434
"msgpack~=1.0",
3535
"asgiref>=3.2.10,<4",
3636
"channels",

tests/test_pubsub.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,8 @@ async def channel_layer():
1919
"""
2020
channel_layer = RedisPubSubChannelLayer(hosts=TEST_HOSTS)
2121
yield channel_layer
22-
await channel_layer.flush()
22+
async with async_timeout.timeout(1):
23+
await channel_layer.flush()
2324

2425

2526
@pytest.fixture()

tests/test_pubsub_sentinel.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,8 @@ async def channel_layer():
2525
"""
2626
channel_layer = RedisPubSubChannelLayer(hosts=TEST_HOSTS)
2727
yield channel_layer
28-
await channel_layer.flush()
28+
async with async_timeout.timeout(1):
29+
await channel_layer.flush()
2930

3031

3132
@pytest.mark.asyncio

0 commit comments

Comments
 (0)