Skip to content

Commit c2f5d90

Browse files
authored
Merge pull request #620 from infosiftr/imagick-php-8
Update imagick for PHP 8 support
2 parents 48e14fd + cdb8362 commit c2f5d90

File tree

22 files changed

+81
-45
lines changed

22 files changed

+81
-45
lines changed

Dockerfile.template

Lines changed: 5 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,6 @@
22
def is_alpine:
33
env.variant | index("alpine")
44
-}}
5-
{{
6-
def has_imagick:
7-
# this is a (hopefully temporary) necessity:
8-
# - https://github.com/docker-library/wordpress/pull/551
9-
# - https://github.com/Imagick/imagick/issues/358
10-
# - https://make.wordpress.org/hosting/handbook/handbook/server-environment/#php-extensions
11-
env.phpVersion | startswith("7")
12-
-}}
135
FROM php:{{ env.phpVersion }}-{{ env.variant }}
146

157
{{ if env.version != "cli" then ( -}}
@@ -19,14 +11,10 @@ RUN set -eux; \
1911
apk add --no-cache \
2012
# in theory, docker-entrypoint.sh is POSIX-compliant, but priority is a working, consistent image
2113
bash \
22-
# BusyBox sed is not sufficient for some of our sed expressions
23-
sed \
2414
# Ghostscript is required for rendering PDF previews
2515
ghostscript \
26-
{{ if has_imagick then ( -}}
2716
# Alpine package for "imagemagick" contains ~120 .so files, see: https://github.com/docker-library/wordpress/pull/497
2817
imagemagick \
29-
{{ ) else "" end -}}
3018
;
3119
{{ ) else ( -}}
3220
RUN set -eux; \
@@ -58,9 +46,7 @@ RUN set -ex; \
5846
apk add --no-cache --virtual .build-deps \
5947
$PHPIZE_DEPS \
6048
freetype-dev \
61-
{{ if has_imagick then ( -}}
6249
imagemagick-dev \
63-
{{ ) else "" end -}}
6450
libjpeg-turbo-dev \
6551
libpng-dev \
6652
libzip-dev \
@@ -72,9 +58,7 @@ RUN set -ex; \
7258
apt-get install -y --no-install-recommends \
7359
libfreetype6-dev \
7460
libjpeg-dev \
75-
{{ if has_imagick then ( -}}
7661
libmagickwand-dev \
77-
{{ ) else "" end -}}
7862
libpng-dev \
7963
libzip-dev \
8064
; \
@@ -97,11 +81,13 @@ RUN set -ex; \
9781
mysqli \
9882
zip \
9983
; \
100-
{{ if has_imagick then ( -}}
101-
pecl install imagick-3.4.4; \
84+
{{ if is_alpine then ( -}}
85+
# WARNING: imagick is likely not supported on Alpine: https://github.com/Imagick/imagick/issues/328
86+
{{ ) else "" end -}}
87+
# https://pecl.php.net/package/imagick
88+
pecl install imagick-3.5.0; \
10289
docker-php-ext-enable imagick; \
10390
rm -r /tmp/pear; \
104-
{{ ) else "" end -}}
10591
\
10692
{{ if is_alpine then ( -}}
10793
runDeps="$( \

beta/php7.3/apache/Dockerfile

Lines changed: 2 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

beta/php7.3/fpm-alpine/Dockerfile

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

beta/php7.3/fpm/Dockerfile

Lines changed: 2 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

beta/php7.4/apache/Dockerfile

Lines changed: 2 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

beta/php7.4/fpm-alpine/Dockerfile

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

beta/php7.4/fpm/Dockerfile

Lines changed: 2 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

beta/php8.0/apache/Dockerfile

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

beta/php8.0/fpm-alpine/Dockerfile

Lines changed: 8 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

beta/php8.0/fpm/Dockerfile

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

cli/php7.3/alpine/Dockerfile

Lines changed: 3 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

cli/php7.4/alpine/Dockerfile

Lines changed: 3 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

cli/php8.0/alpine/Dockerfile

Lines changed: 6 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

latest/php7.3/apache/Dockerfile

Lines changed: 2 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

latest/php7.3/fpm-alpine/Dockerfile

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

latest/php7.3/fpm/Dockerfile

Lines changed: 2 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

latest/php7.4/apache/Dockerfile

Lines changed: 2 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

latest/php7.4/fpm-alpine/Dockerfile

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

latest/php7.4/fpm/Dockerfile

Lines changed: 2 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

latest/php8.0/apache/Dockerfile

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

latest/php8.0/fpm-alpine/Dockerfile

Lines changed: 8 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)