Skip to content

Allow to use other glyphs for trees #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
memeplex opened this issue Feb 18, 2019 · 1 comment
Open

Allow to use other glyphs for trees #263

memeplex opened this issue Feb 18, 2019 · 1 comment
Labels
is:feature Adds or requests new features, or extends existing ones
Milestone

Comments

@memeplex
Copy link

memeplex commented Feb 18, 2019

Given that you intentionally are using just a handful of glyphs (as discussed in #262) could you:

  1. Just call propertize by hand instead of using the all-the-icons wrapper. This is a simple change, the wrapper is handy but it's not a big deal anyway.

  2. Allow the user to provide a string/list/alist with the few glyphs you have to set.

I'm requesting this because many users probably have Nerd fonts or similar installed in their system and the dependency on all-the-icons is a source of potential conflicts, I guess. And even if it isn't it would be cleaner to provide 5 or 6 fonts without the need to install 6 font families first (btw, the all-the-icons installer is broken).

I don't mean to remove all-the-icons support altogether, of course, it's a good fallback. Just to give a hook to users (probably the ones on arch linux) already using glyphs packages of their liking.

@memeplex
Copy link
Author

Just in case the above is not clear, the intention is to resolve the glyph in the list provided by the user and, when unable to do so, to fetch the corresponding all-the-icons glyph as a fallback. Then apply propertize on the resolved glyph. So the all-the-icons machinery will be fetching fonts by name without applying further properties.

@hlissner hlissner added the is:feature Adds or requests new features, or extends existing ones label May 21, 2019
@hlissner hlissner added the help wanted Cannot be resolved without outside help label Jun 28, 2019
@hlissner hlissner added this to Triage Apr 21, 2022
@hlissner hlissner moved this to Unreviewed in Triage Apr 21, 2022
@hlissner hlissner added this to the Backlog milestone Apr 22, 2022
@hlissner hlissner moved this from Unreviewed to Unknown in Triage Apr 22, 2022
@hlissner hlissner removed the help wanted Cannot be resolved without outside help label Apr 22, 2022
@hlissner hlissner moved this from Unknown to Unreviewed in Triage Apr 22, 2022
@hlissner hlissner moved this from Unreviewed to Unknown in Triage Apr 22, 2022
@hlissner hlissner moved this from Unknown to Blocked in Triage Feb 15, 2024
@hlissner hlissner removed this from Triage Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is:feature Adds or requests new features, or extends existing ones
Projects
None yet
Development

No branches or pull requests

2 participants