Skip to content

Commit 33515b0

Browse files
committed
Fix after rebase
1 parent 468b5b7 commit 33515b0

File tree

3 files changed

+4
-6
lines changed

3 files changed

+4
-6
lines changed

src/Xamarin.Android.Build.Tasks/Tasks/GenerateMainAndroidManifest.cs

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ public class GenerateMainAndroidManifest : AndroidTask
2525
public string? CheckedBuild { get; set; }
2626
public bool Debug { get; set; }
2727
public bool EmbedAssemblies { get; set; }
28-
public bool EnableMarshalMethods { get; set; }
2928
public bool EnableNativeRuntimeLinking { get; set; }
3029
[Required]
3130
public string IntermediateOutputDirectory { get; set; } = "";
@@ -66,10 +65,9 @@ public override bool RunTask ()
6665

6766
AdditionalProviderSources = additionalProviders.ToArray ();
6867

69-
// If we still need the NativeCodeGenState in the <GenerateNativeMarshalMethodSources> task because we're using marshal methods,
70-
// we're going to transfer it to a new object that doesn't require holding open Cecil AssemblyDefinitions.
71-
if (UseMarshalMethods || EnableNativeRuntimeLinking) {
72-
var nativeCodeGenStateObject = MarshalMethodCecilAdapter.GetNativeCodeGenStateCollection (Log, nativeCodeGenStates);
68+
// We still need the NativeCodeGenState for later tasks, but we're going to transfer
69+
// it to a new object that doesn't require holding open Cecil AssemblyDefinitions.
70+
var nativeCodeGenStateObject = MarshalMethodCecilAdapter.GetNativeCodeGenStateCollection (Log, nativeCodeGenStates);
7371

7472
Log.LogDebugMessage ($"Saving {nameof (NativeCodeGenStateObject)} to {nameof (GenerateJavaStubs.NativeCodeGenStateObjectRegisterTaskKey)}");
7573
BuildEngine4.RegisterTaskObjectAssemblyLocal (MonoAndroidHelper.GetProjectBuildSpecificTaskObjectKey (GenerateJavaStubs.NativeCodeGenStateObjectRegisterTaskKey, WorkingDirectory, IntermediateOutputDirectory), nativeCodeGenStateObject, RegisteredTaskObjectLifetime.Build);

src/Xamarin.Android.Build.Tasks/Utilities/MarshalMethodCecilAdapter.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -160,6 +160,7 @@ class NativeCodeGenStateObject
160160
public Dictionary<string, IList<MarshalMethodEntryObject>> MarshalMethods { get; } = [];
161161
public List<PinvokeScanner.PinvokeEntryInfo>? PinvokeInfos { get; set; }
162162
public AndroidTargetArch TargetArch { get; set; } = AndroidTargetArch.None;
163+
public List<(string JniName, string AssemblyQualifiedName)> ApplicationsAndInstrumentationsToRegister { get; } = [];
163164
}
164165

165166
class MarshalMethodEntryObject

src/Xamarin.Android.Build.Tasks/Xamarin.Android.Common.targets

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1660,7 +1660,6 @@ because xbuild doesn't support framework reference assemblies.
16601660
CheckedBuild="$(_AndroidCheckedBuild)"
16611661
Debug="$(AndroidIncludeDebugSymbols)"
16621662
EmbedAssemblies="$(EmbedAssembliesIntoApk)"
1663-
EnableMarshalMethods="$(_AndroidUseMarshalMethods)"
16641663
EnableNativeRuntimeLinking="$(_AndroidEnableNativeRuntimeLinking)"
16651664
IntermediateOutputDirectory="$(IntermediateOutputPath)"
16661665
ManifestPlaceholders="$(AndroidManifestPlaceholders)"

0 commit comments

Comments
 (0)