Refactor method

martincostello · martincostello · commit ec9e760a1ab0 · 2025-06-17T13:12:41.000+01:00
Use `Convert.ToString()` instead of a format string.
diff --git a/src/OpenApi/src/Extensions/JsonNodeSchemaExtensions.cs b/src/OpenApi/src/Extensions/JsonNodeSchemaExtensions.cs
@@ -97,8 +97,8 @@ internal static void ApplyValidationAttributes(this JsonNode schema, IEnumerable
                     ? CultureInfo.InvariantCulture
                     : CultureInfo.CurrentCulture;
 
-                var minString = string.Format(targetCulture, "{0}", rangeAttribute.Minimum);
-                var maxString = string.Format(targetCulture, "{0}", rangeAttribute.Maximum);
+                var minString = Convert.ToString(rangeAttribute.Minimum, targetCulture);
+                var maxString = Convert.ToString(rangeAttribute.Maximum, targetCulture);
 
                 if (decimal.TryParse(minString, NumberStyles.Any, targetCulture, out var minDecimal))
                 {

Original file line number	Diff line number	Diff line change
`@@ -97,8 +97,8 @@ internal static void ApplyValidationAttributes(this JsonNode schema, IEnumerable`
`97`	`97`	`? CultureInfo.InvariantCulture`
`98`	`98`	`: CultureInfo.CurrentCulture;`
`99`	`99`
`100`		`- var minString = string.Format(targetCulture, "{0}", rangeAttribute.Minimum);`
`101`		`- var maxString = string.Format(targetCulture, "{0}", rangeAttribute.Maximum);`
	`100`	`+ var minString = Convert.ToString(rangeAttribute.Minimum, targetCulture);`
	`101`	`+ var maxString = Convert.ToString(rangeAttribute.Maximum, targetCulture);`
`102`	`102`
`103`	`103`	`if (decimal.TryParse(minString, NumberStyles.Any, targetCulture, out var minDecimal))`
`104`	`104`	`{`