-
Notifications
You must be signed in to change notification settings - Fork 134
[main] CLI-based tools in eng directory failing to build with error CS0246 #5054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@ViktorHofer - Looks like the version of Arcade being used here doesn't yet bring in the new S.CL changes. Do you know the story here? |
This is also failing in the CreateBaselineUpdatePR project:
https://dev.azure.com/dnceng/internal/_build/results?buildId=2689642&view=results (internal link) |
Scan for binaries
failing with error CS0246
The stage2 build in the VMR got fixed today with dotnet/dotnet@f09dba3 Are these components using different dependencies somehow? |
Is there a binlog that I can take a look at? |
These tools are just using Arcade to install the SDK, which is using the version from the global.json. |
No binlog is captured for these tools. |
This is the SDK it's installing: https://ci.dot.net/public/Sdk/10.0.100-preview.4.25216.3/dotnet-sdk-10.0.100-preview.4.25216.3-linux-x64.tar.gz |
Also filed #5055 |
Is this going to require a re-bootstrap to pick up the fix? |
No. The impacted tools (BinaryToolKit (for tagging), CreateBaselineUpdatePR and BuildComparer) use the version that is specified in Versions.props, regardless of the SDK and PSB. The latest build is already green: https://dev.azure.com/dnceng/internal/_build/results?buildId=2689702&view=results |
My suggestion in #4976 (comment) would have prevented this. We should be using the PSB versions in source-build scenarios. ...But we should still be updating the versions.props appropriately. |
Agreed. It would be great if we could add support for that in source-build scenarios. That said, tools that run inside a source-only context still depend on an accurate version in Versions.props / Directory.Packages.props. FWIW referencing the tool projects (BuildComparer, CreateBaselineUpdatePR and BinaryToolKit) in tools.proj would've also prevented this. |
Related to dotnet/sdk#48523
https://dev.azure.com/dnceng/internal/_build/results?buildId=2689462&view=logs&j=fa5c2909-0e29-5671-d5eb-16d6c40e0c4a&t=2a0bd486-3f67-5c59-da0c-b84d88848a4b&l=23 (internal Microsoft link)
Scan for binaries
building failed with below message:The text was updated successfully, but these errors were encountered: