Skip to content

Commit 1118da2

Browse files
authored
Merge pull request #96 from salemove/fix/websocket_onclosing
Fix WebSocket not closed in onClosing
2 parents 5248447 + 28f0086 commit 1118da2

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

src/main/kotlin/org/phoenixframework/Transport.kt

+1
Original file line numberDiff line numberDiff line change
@@ -155,6 +155,7 @@ class WebSocketTransport(
155155

156156
override fun onClosing(webSocket: WebSocket, code: Int, reason: String) {
157157
this.readyState = Transport.ReadyState.CLOSING
158+
webSocket.close(code, reason)
158159
}
159160

160161
override fun onMessage(webSocket: WebSocket, text: String) {

src/test/kotlin/org/phoenixframework/WebSocketTransportTest.kt

+1
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,7 @@ class WebSocketTransportTest {
136136
transport.readyState = Transport.ReadyState.OPEN
137137

138138
transport.onClosing(mockWebSocket, 10, "reason")
139+
verify(mockWebSocket).close(10, "reason")
139140
assertThat(transport.readyState).isEqualTo(Transport.ReadyState.CLOSING)
140141
}
141142

0 commit comments

Comments
 (0)