Skip to content

Commit f337a20

Browse files
authored
Merge pull request #316 from dtolnay/build
Use more systematic naming for generated code targets
2 parents dbfdbd7 + dc57990 commit f337a20

File tree

4 files changed

+32
-32
lines changed

4 files changed

+32
-32
lines changed

demo/BUCK

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4,49 +4,49 @@ rust_binary(
44
name = "demo",
55
srcs = glob(["src/**/*.rs"]),
66
deps = [
7+
":bridge",
78
":demo-sys",
8-
":gen",
99
"//:cxx",
1010
],
1111
)
1212

1313
cxx_library(
14-
name = "gen",
15-
srcs = [":gen-source"],
14+
name = "bridge",
15+
srcs = [":bridge/source"],
1616
deps = [
17+
":bridge/include",
1718
":demo-include",
18-
":include",
1919
],
2020
)
2121

2222
genrule(
23-
name = "gen-header",
23+
name = "bridge/header",
2424
srcs = ["src/main.rs"],
2525
out = "src/main.rs.h",
2626
cmd = "$(exe //:codegen) --header ${SRCS} > ${OUT}",
2727
type = "cxxbridge",
2828
)
2929

3030
genrule(
31-
name = "gen-source",
31+
name = "bridge/source",
3232
srcs = ["src/main.rs"],
3333
out = "src/main.rs.cc",
3434
cmd = "$(exe //:codegen) ${SRCS} > ${OUT}",
3535
type = "cxxbridge",
3636
)
3737

3838
cxx_library(
39-
name = "include",
40-
exported_headers = [":gen-header"],
39+
name = "bridge/include",
40+
exported_headers = [":bridge/header"],
4141
)
4242

4343
cxx_library(
4444
name = "demo-sys",
4545
srcs = ["src/demo.cc"],
4646
compiler_flags = ["-std=c++14"],
4747
deps = [
48+
":bridge/include",
4849
":demo-include",
49-
":include",
5050
],
5151
)
5252

demo/BUILD

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -5,49 +5,49 @@ rust_binary(
55
name = "demo",
66
srcs = glob(["src/**/*.rs"]),
77
deps = [
8+
":bridge",
89
":demo-sys",
9-
":gen",
1010
"//:cxx",
1111
],
1212
)
1313

1414
cc_library(
15-
name = "gen",
16-
srcs = [":gen-source"],
15+
name = "bridge",
16+
srcs = [":bridge/source"],
1717
deps = [
18+
":bridge/include",
1819
":demo-include",
19-
":include",
2020
],
2121
)
2222

2323
genrule(
24-
name = "gen-header",
24+
name = "bridge/header",
2525
srcs = ["src/main.rs"],
2626
outs = ["src/main.rs.h"],
2727
cmd = "$(location //:codegen) --header $< > $@",
2828
tools = ["//:codegen"],
2929
)
3030

3131
genrule(
32-
name = "gen-source",
32+
name = "bridge/source",
3333
srcs = ["src/main.rs"],
3434
outs = ["src/main.rs.cc"],
3535
cmd = "$(location //:codegen) $< > $@",
3636
tools = ["//:codegen"],
3737
)
3838

3939
cc_library(
40-
name = "include",
41-
hdrs = [":gen-header"],
40+
name = "bridge/include",
41+
hdrs = [":bridge/header"],
4242
)
4343

4444
cc_library(
4545
name = "demo-sys",
4646
srcs = ["src/demo.cc"],
4747
copts = ["-std=c++14"],
4848
deps = [
49+
":bridge/include",
4950
":demo-include",
50-
":include",
5151
],
5252
)
5353

tests/BUCK

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,33 +23,33 @@ cxx_library(
2323
name = "impl",
2424
srcs = [
2525
"ffi/tests.cc",
26-
":gen-lib-source",
27-
":gen-module-source",
26+
":bridge/source",
27+
":module/source",
2828
],
2929
header_namespace = "cxx-test-suite",
3030
headers = {
31-
"lib.rs.h": ":gen-lib-header",
31+
"lib.rs.h": ":bridge/header",
3232
"tests.h": "ffi/tests.h",
3333
},
3434
deps = ["//:core"],
3535
)
3636

3737
genrule(
38-
name = "gen-lib-header",
38+
name = "bridge/header",
3939
srcs = ["ffi/lib.rs"],
4040
out = "ffi/lib.rs.h",
4141
cmd = "$(exe //:codegen) --header ${SRCS} > ${OUT}",
4242
)
4343

4444
genrule(
45-
name = "gen-lib-source",
45+
name = "bridge/source",
4646
srcs = ["ffi/lib.rs"],
4747
out = "ffi/lib.rs.cc",
4848
cmd = "$(exe //:codegen) ${SRCS} > ${OUT}",
4949
)
5050

5151
genrule(
52-
name = "gen-module-source",
52+
name = "module/source",
5353
srcs = ["ffi/module.rs"],
5454
out = "ffi/module.rs.cc",
5555
cmd = "$(exe //:codegen) ${SRCS} > ${OUT}",

tests/BUILD

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -24,43 +24,43 @@ cc_library(
2424
name = "impl",
2525
srcs = [
2626
"ffi/tests.cc",
27-
":gen-lib-source",
28-
":gen-module-source",
27+
":bridge/source",
28+
":module/source",
2929
],
3030
hdrs = ["ffi/tests.h"],
3131
include_prefix = "cxx-test-suite",
3232
strip_include_prefix = "ffi",
3333
deps = [
34-
":lib-include",
34+
":bridge/include",
3535
"//:core",
3636
],
3737
)
3838

3939
genrule(
40-
name = "gen-lib-header",
40+
name = "bridge/header",
4141
srcs = ["ffi/lib.rs"],
4242
outs = ["ffi/lib.rs.h"],
4343
cmd = "$(location //:codegen) --header $< > $@",
4444
tools = ["//:codegen"],
4545
)
4646

4747
genrule(
48-
name = "gen-lib-source",
48+
name = "bridge/source",
4949
srcs = ["ffi/lib.rs"],
5050
outs = ["ffi/lib.rs.cc"],
5151
cmd = "$(location //:codegen) $< > $@",
5252
tools = ["//:codegen"],
5353
)
5454

5555
cc_library(
56-
name = "lib-include",
57-
hdrs = [":gen-lib-header"],
56+
name = "bridge/include",
57+
hdrs = [":bridge/header"],
5858
include_prefix = "cxx-test-suite",
5959
strip_include_prefix = "ffi",
6060
)
6161

6262
genrule(
63-
name = "gen-module-source",
63+
name = "module/source",
6464
srcs = ["ffi/module.rs"],
6565
outs = ["ffi/module.rs.cc"],
6666
cmd = "$(location //:codegen) $< > $@",

0 commit comments

Comments
 (0)