Skip to content

Commit 33f854b

Browse files
committed
Command-line ignore let_underscore_drop clippy lint
For whatever reason, the #![cfg_attr(feature = "cargo-clippy", allow(let_underscore_drop))] attributes already in the code stopped working in the most recent nightly (2022-09-03). Likely in connection with rust-lang/rust#97739 ? error: non-binding `let` on a type that implements `Drop` --> build.rs:8:5 | 8 | let _ = fs::remove_dir_all(&out_dir); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `-D clippy::let-underscore-drop` implied by `-D clippy::pedantic` = help: consider using an underscore-prefixed named binding or dropping explicitly with `std::mem::drop` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_drop error: non-binding `let` on a type that implements `Drop` --> build.rs:9:5 | 9 | let _ = fs::create_dir(&out_dir); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: consider using an underscore-prefixed named binding or dropping explicitly with `std::mem::drop` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_drop error: non-binding `let` on a type that implements `Drop` --> src/lib.rs:128:5 | 128 | let _ = fs::create_dir(&p); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `-D clippy::let-underscore-drop` implied by `-D clippy::pedantic` = help: consider using an underscore-prefixed named binding or dropping explicitly with `std::mem::drop` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_drop
1 parent 065b58c commit 33f854b

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ jobs:
3535
steps:
3636
- uses: actions/checkout@v3
3737
- uses: dtolnay/rust-toolchain@clippy
38-
- run: cargo clippy -- -Dclippy::all -Dclippy::pedantic
38+
- run: cargo clippy -- -Dclippy::all -Dclippy::pedantic -Aclippy::let_underscore_drop
3939

4040
outdated:
4141
name: Outdated

0 commit comments

Comments
 (0)