-
-
Notifications
You must be signed in to change notification settings - Fork 28
Move token_stream_parse implementation to Wasm #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
One thing I should note on this is that I was surprised that |
Does that include time spent running In addition, given the higher minimum rustc version for |
Oh right that's an excellent point! Yes the timing information of |
@dtolnay benchmarked an impl of this in #26 (review), and found it had equivalent (or worse) performance, even on large inputs. I'm inclined to think that we should leave the |
As noted in #2 (comment),
We'll need to import something like https://github.com/alexcrichton/proc-macro2/blob/1.0.6/src/strnom.rs and use that to implement token stream parsing rather than calling out to a host func.
It's possible we can simplify the implementation from proc-macro2 by omitting the parts that deal with parsing comments, as those won't appear in our use case.
The text was updated successfully, but these errors were encountered: