Skip to content

Commit d0e596e

Browse files
committed
Make sails.getRouteFor() usage error message a bit clearer
1 parent 51599b4 commit d0e596e

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

Diff for: .eslintrc

+1-2
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,7 @@
1919
},
2020

2121
"parserOptions": {
22-
"ecmaVersion": 5
23-
// ^^This can be changed to `8` if this package doesn't need to support <= Node v6.
22+
"ecmaVersion": 8
2423
},
2524

2625
"globals": {

Diff for: lib/app/get-route-for.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ module.exports = function getRouteFor(routeQuery){
4242
try {
4343
actionToLookup = sails.router.getActionIdentityForTarget(routeQuery);
4444
} catch (unusedErr) { // FUTURE: provide access to error details instead of swallowing
45-
var invalidUsageErr = new Error('Usage error: `sails.getRouteFor()` expects a string route target (e.g. "DuckController.quack") or a dictionary with either a target property (e.g. `{target: "DuckController.quack"}`) or an action property (e.g. `{controller: "duck", action: "quack"}` or `{action: "duck/quack"}`). But instead, it received a `'+typeof routeQuery+'`: '+util.inspect(routeQuery, {depth: null}) );
45+
var invalidUsageErr = new Error(`Usage error: sails.getRouteFor() expects a string route target (e.g. "DuckController.quack") or a dictionary with either a "target" (e.g. {target: "DuckController.quack"}) or an "action" (e.g. {controller: "duck", action: "quack"} or {action: "duck/quack"}). But instead, it received a ${typeof routeQuery}: ${util.inspect(routeQuery, {depth: null})}`);
4646
invalidUsageErr.code = 'E_USAGE';
4747
throw invalidUsageErr;
4848
}

0 commit comments

Comments
 (0)