Fix #7 - skip pypi release if the db diff doesn't contain any changes

Author: cmdr2

.github/workflows/pci-update-workflow.yml

@@ -33,53 +33,64 @@ jobs:
         run: |
           curl -o pci.ids.new https://raw.githubusercontent.com/pciutils/pciids/master/pci.ids
 
-      - name: Check for changes
-        id: check_changes
+      - name: Check for sha256 change
+        id: check_sha256
         run: |
           # Calculate new checksum
           NEW_CHECKSUM=$(sha256sum pci.ids.new | cut -d' ' -f1)
           
           # Check if checksum file exists and compare
           if [ ! -f pci.ids.sha256 ]; then
-            echo "No existing checksum file found. Will proceed with update."
+            echo "Cached checksum file not found. Will proceed with update."
             echo "has_changes=true" >> "$GITHUB_OUTPUT"
             echo "$NEW_CHECKSUM" > pci.ids.sha256
           else
             OLD_CHECKSUM=$(cat pci.ids.sha256)
             if [ "$NEW_CHECKSUM" != "$OLD_CHECKSUM" ]; then
-              echo "Changes detected in pci.ids file"
+              echo "pci.ids checksum is different"
               echo "$NEW_CHECKSUM" > pci.ids.sha256
               echo "has_changes=true" >> "$GITHUB_OUTPUT"
             else
-              echo "No changes detected in pci.ids file"
+              echo "No changes detected in pci.ids"
               echo "has_changes=false" >> "$GITHUB_OUTPUT"
               rm pci.ids.new
               exit 0
             fi
           fi
 
       - name: Update files and generate database
-        if: steps.check_changes.outputs.has_changes == 'true'
+        if: steps.check_sha256.outputs.has_changes == 'true'
         run: |
           mv torchruntime/gpu_pci_ids.db old.db
           export PYTHONPATH=$PYTHONPATH:$(pwd)
           python scripts/txt_to_db.py pci.ids.new torchruntime/gpu_pci_ids.db
 
       - name: Get the DB diff
-        if: steps.check_changes.outputs.has_changes == 'true'
+        id: check_db_diff
+        if: steps.check_sha256.outputs.has_changes == 'true'
         run: |
           python scripts/sqldiff.py old.db torchruntime/gpu_pci_ids.db > db_diff.txt
+          diff_count=$(cat db_diff.txt | wc -l)
+          if [ "$diff_count" -eq "0" ]; then
+            echo "No changes detected in db diff"
+            echo "has_changes=false" >> "$GITHUB_OUTPUT"
+            exit 0
+          else
+            echo "db diff is different"
+            cat db_diff.txt
+            echo "has_changes=true" >> "$GITHUB_OUTPUT"
+          fi
           echo 'DIFF_OUTPUT<<EOF' >> $GITHUB_ENV
           cat db_diff.txt >> $GITHUB_ENV
           echo 'EOF' >> $GITHUB_ENV
 
       - name: Run tests
-        if: steps.check_changes.outputs.has_changes == 'true'
+        if: steps.check_db_diff.outputs.has_changes == 'true'
         run: |
           python -m pytest
 
       - name: Update version in pyproject.toml
-        if: steps.check_changes.outputs.has_changes == 'true'
+        if: steps.check_db_diff.outputs.has_changes == 'true'
         id: update_version
         run: |
           python - <<EOF
@@ -111,19 +122,19 @@ jobs:
           ls -l torchruntime/gpu_pci_ids.db
 
       - name: Configure Git
-        if: steps.check_changes.outputs.has_changes == 'true'
+        if: steps.check_db_diff.outputs.has_changes == 'true'
         run: |
           git config --local user.email "github-actions[bot]@users.noreply.github.com"
           git config --local user.name "github-actions[bot]"
 
       - name: Commit changes
-        if: steps.check_changes.outputs.has_changes == 'true'
+        if: steps.check_db_diff.outputs.has_changes == 'true'
         run: |
           git add pci.ids.sha256 torchruntime/gpu_pci_ids.db pyproject.toml
           git commit -m "Update PCI database, raw data file and version"
 
       - name: Create Release
-        if: steps.check_changes.outputs.has_changes == 'true'
+        if: steps.check_db_diff.outputs.has_changes == 'true'
         uses: softprops/action-gh-release@v1
         with:
           tag_name: v${{ steps.update_version.outputs.new_version }}
@@ -136,7 +147,7 @@ jobs:
           prerelease: false
 
       - name: Push changes
-        if: steps.check_changes.outputs.has_changes == 'true'
+        if: steps.check_db_diff.outputs.has_changes == 'true'
         run: git push && git push --tags
 
       - name: Cleanup

scripts/sqldiff.py

@@ -23,16 +23,21 @@
 cols = cursor1.execute(COL_NAME_QUERY).fetchall()
 cols = tuple(col[1] for col in cols)
 
-print("### Additions")
-print("```")
-print(cols)
-for row in res2 - res1:
-    print(row)
-print("```")
-
-print("### Deletions")
-print("```")
-print(cols)
-for row in res1 - res2:
-    print(row)
-print("```")
+additions = res2 - res1
+deletions = res1 - res2
+
+if additions:
+    print("### Additions")
+    print("```")
+    print(cols)
+    for row in additions:
+        print(row)
+    print("```")
+
+if deletions:
+    print("### Deletions")
+    print("```")
+    print(cols)
+    for row in deletions:
+        print(row)
+    print("```")