Skip to content

Move x/codegen/J9TreeEvaluator.cpp evaluators to i386/amd64 #21549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
0xdaryl opened this issue Apr 1, 2025 · 0 comments
Open

Move x/codegen/J9TreeEvaluator.cpp evaluators to i386/amd64 #21549

0xdaryl opened this issue Apr 1, 2025 · 0 comments

Comments

@0xdaryl
Copy link
Contributor

0xdaryl commented Apr 1, 2025

There are some function implementations in the common x86 J9TreeEvaluator class that are ifdefed for 32-bit and 64-bit (e.g., [1] and [2], among others) which doesn't follow the idioms of extensible classes. These functions should be moved into appropriate architecture-specific files without ifdefs (i.e., a i386/codegen/J9TreeEvaluator.cpp and a amd64/codegen/J9TreeEvaluator.cpp). Neither of these files exist, so they will have to be created.

Sweep through x/codegen/J9TreeEvaluator.cpp and move evaluator functions ifdefed for an architecture.

[1]


[2]
#ifdef TR_TARGET_64BIT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants