You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are some function implementations in the common x86 J9TreeEvaluator class that are ifdefed for 32-bit and 64-bit (e.g., [1] and [2], among others) which doesn't follow the idioms of extensible classes. These functions should be moved into appropriate architecture-specific files without ifdefs (i.e., a i386/codegen/J9TreeEvaluator.cpp and a amd64/codegen/J9TreeEvaluator.cpp). Neither of these files exist, so they will have to be created.
Sweep through x/codegen/J9TreeEvaluator.cpp and move evaluator functions ifdefed for an architecture.
There are some function implementations in the common x86 J9TreeEvaluator class that are
ifdef
ed for 32-bit and 64-bit (e.g., [1] and [2], among others) which doesn't follow the idioms of extensible classes. These functions should be moved into appropriate architecture-specific files without ifdefs (i.e., ai386/codegen/J9TreeEvaluator.cpp
and aamd64/codegen/J9TreeEvaluator.cpp
). Neither of these files exist, so they will have to be created.Sweep through
x/codegen/J9TreeEvaluator.cpp
and move evaluator functionsifdef
ed for an architecture.[1]
openj9/runtime/compiler/x/codegen/J9TreeEvaluator.cpp
Line 968 in 7431737
[2]
openj9/runtime/compiler/x/codegen/J9TreeEvaluator.cpp
Line 13722 in 7431737
The text was updated successfully, but these errors were encountered: