From 7481d26a68d0d13ff13b93c0f4931891102894fd Mon Sep 17 00:00:00 2001 From: Kristianmitk Date: Tue, 18 Feb 2020 11:33:13 +0100 Subject: [PATCH 1/2] free definitely lost memory from libhrd_cpp --- libhrd_cpp/hrd_util.cc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libhrd_cpp/hrd_util.cc b/libhrd_cpp/hrd_util.cc index 39703c3..ea60b8b 100644 --- a/libhrd_cpp/hrd_util.cc +++ b/libhrd_cpp/hrd_util.cc @@ -331,6 +331,7 @@ memcached_st* hrd_create_memc() { rc = memcached_server_push(memc, servers); rt_assert(rc == MEMCACHED_SUCCESS, "Couldn't add memcached server"); + memcached_server_list_free(servers); return memc; } @@ -429,10 +430,12 @@ void hrd_wait_till_ready(const char* qp_name) { tries++; if (ret > 0) { if (strcmp(value, exp_value) == 0) { + free(value); return; } } + free(value); usleep(200000); if (tries > 100) { From db40d72ecb6713ff7b9f64fc9983455762829a21 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kristian=20Br=C3=BCnn?= <11316874+kristianmitk@users.noreply.github.com> Date: Tue, 18 Feb 2020 17:44:28 +0100 Subject: [PATCH 2/2] remove duplicate memcached_create(nullptr) call --- libhrd_cpp/hrd_util.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libhrd_cpp/hrd_util.cc b/libhrd_cpp/hrd_util.cc index ea60b8b..5a265ce 100644 --- a/libhrd_cpp/hrd_util.cc +++ b/libhrd_cpp/hrd_util.cc @@ -319,7 +319,7 @@ void hrd_get_formatted_time(char* timebuf) { memcached_st* hrd_create_memc() { memcached_server_st* servers = nullptr; - memcached_st* memc = memcached_create(nullptr); + memcached_st* memc = nullptr; memcached_return rc; memc = memcached_create(nullptr);