Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SP Pallet: Investigate deal weight #459

Open
aidan46 opened this issue Oct 17, 2024 · 0 comments
Open

SP Pallet: Investigate deal weight #459

aidan46 opened this issue Oct 17, 2024 · 0 comments
Labels
frozen PR/Issue is on hold needs clarification pallet-storage-provider Relates to the Storage Provider Pallet research

Comments

@aidan46
Copy link
Contributor

aidan46 commented Oct 17, 2024

Ticket created from a PR comment:
So we put here all of the sectors that expired (current_block > expired) and we're sure that they have data.
I don't know how it can happen that a sector has no data and what's the weight has to do with it.
Let's create a follow-up to investigate, or wdyt?

Originally posted by @th7nder in #451 (comment)

In FC they use deal weight to determine if a terminated sector still has data left in it. We check if the sector has expired or not.
@aidan46 aidan46 self-assigned this Oct 17, 2024
@aidan46 aidan46 added research pallet-storage-provider Relates to the Storage Provider Pallet labels Oct 17, 2024
@aidan46 aidan46 mentioned this issue Oct 17, 2024
Merged
@jmg-duarte jmg-duarte modified the milestone: Phase 3 Nov 14, 2024
@jmg-duarte jmg-duarte added the frozen PR/Issue is on hold label Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
frozen PR/Issue is on hold needs clarification pallet-storage-provider Relates to the Storage Provider Pallet research
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jmg-duarte @aidan46