Incompatibility with setuptools >= 78.0.0

[romeroyonatan]

Setuptools deprecated dash-separated settings

From NEWS.rst:

Setuptools no longer accepts options containing uppercase or dash characters in setup.cfg. Please ensure to write the options in setup.cfg using the :wiki:lower_snake_case <Snake_case> convention (e.g. Name => name, install-requires => install_requires). This is a follow-up on deprecations introduced in v54.1.0 (see #1608) and v54.1.1 (see #2592).

How to reproduce

$ pip install python-quickbooks
Collecting python-quickbooks
  Downloading python-quickbooks-0.9.11.tar.gz (34 kB)
  Installing build dependencies ... done
  Getting requirements to build wheel ... error
  error: subprocess-exited-with-error

  × Getting requirements to build wheel did not run successfully.
  │ exit code: 1
  ╰─> [34 lines of output]
      Traceback (most recent call last):
        File "/private/tmp/a/.venv/lib/python3.12/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 389, in <module>
          main()
        File "/private/tmp/a/.venv/lib/python3.12/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 373, in main
          json_out["return_val"] = hook(**hook_input["kwargs"])
                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/private/tmp/a/.venv/lib/python3.12/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 143, in get_requires_for_build_wheel
          return hook(config_settings)
                 ^^^^^^^^^^^^^^^^^^^^^
        File "/private/var/folders/43/lf0wjcj94m5b57fm6s96b8ww0000gp/T/pip-build-env-t8z4jf0n/overlay/lib/python3.12/site-packages/setuptools/build_meta.py", line 334, in get_requires_for_build_wheel
          return self._get_build_requires(config_settings, requirements=[])
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/private/var/folders/43/lf0wjcj94m5b57fm6s96b8ww0000gp/T/pip-build-env-t8z4jf0n/overlay/lib/python3.12/site-packages/setuptools/build_meta.py", line 304, in _get_build_requires
          self.run_setup()
        File "/private/var/folders/43/lf0wjcj94m5b57fm6s96b8ww0000gp/T/pip-build-env-t8z4jf0n/overlay/lib/python3.12/site-packages/setuptools/build_meta.py", line 522, in run_setup
          super().run_setup(setup_script=setup_script)
        File "/private/var/folders/43/lf0wjcj94m5b57fm6s96b8ww0000gp/T/pip-build-env-t8z4jf0n/overlay/lib/python3.12/site-packages/setuptools/build_meta.py", line 320, in run_setup
          exec(code, locals())
        File "<string>", line 16, in <module>
        File "/private/var/folders/43/lf0wjcj94m5b57fm6s96b8ww0000gp/T/pip-build-env-t8z4jf0n/overlay/lib/python3.12/site-packages/setuptools/__init__.py", line 116, in setup
          _install_setup_requires(attrs)
        File "/private/var/folders/43/lf0wjcj94m5b57fm6s96b8ww0000gp/T/pip-build-env-t8z4jf0n/overlay/lib/python3.12/site-packages/setuptools/__init__.py", line 87, in _install_setup_requires
          dist.parse_config_files(ignore_option_errors=True)
        File "/private/tmp/a/.venv/lib/python3.12/site-packages/_virtualenv.py", line 20, in parse_config_files
          result = old_parse_config_files(self, *args, **kwargs)
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/private/var/folders/43/lf0wjcj94m5b57fm6s96b8ww0000gp/T/pip-build-env-t8z4jf0n/overlay/lib/python3.12/site-packages/setuptools/dist.py", line 730, in parse_config_files
          self._parse_config_files(filenames=inifiles)
        File "/private/var/folders/43/lf0wjcj94m5b57fm6s96b8ww0000gp/T/pip-build-env-t8z4jf0n/overlay/lib/python3.12/site-packages/setuptools/dist.py", line 599, in _parse_config_files
          opt = self._enforce_underscore(opt, section)
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/private/var/folders/43/lf0wjcj94m5b57fm6s96b8ww0000gp/T/pip-build-env-t8z4jf0n/overlay/lib/python3.12/site-packages/setuptools/dist.py", line 629, in _enforce_underscore
          raise InvalidConfigError(
      setuptools.errors.InvalidConfigError: Invalid dash-separated key 'description-file' in 'metadata' (setup.cfg), please use the underscore name 'description_file' instead.
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: subprocess-exited-with-error

× Getting requirements to build wheel did not run successfully.
│ exit code: 1
╰─> See above for output.

note: This error originates from a subprocess, and is likely not a problem with pip.

[romeroyonatan]

Suggested fix: #382

[romeroyonatan]

Workarround: Install setuptools < 78 and add --no-build-isolation flag

pip install 'setuptools<78'
pip install python-quickbooks --no-build-isolation

[ShedPlant]

Note that setuptools have rolled back the break: pypa/setuptools#4911

But please make this change anyway since it seems they intend to break it again next year 🤷

[ej2]

Fixed in 0.9.12