Skip to content

Remove ember-cli-string-helpers addon #1666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
barryofguilder opened this issue Apr 3, 2025 · 1 comment · Fixed by #1672
Closed

Remove ember-cli-string-helpers addon #1666

barryofguilder opened this issue Apr 3, 2025 · 1 comment · Fixed by #1672

Comments

@barryofguilder
Copy link
Contributor

When I upgrade my addon to use @ember/string v4.0, my addon build will throw an error that says:

"Module not found: Error: ember-cli-string-helpers is trying to import the app's @ember/string package, but it seems to be missing"

I noticed that the ember-cli-string-helpers addon was archived in October 2024. I think it would be a good idea to remove this package and replace it with something that is maintained. For now, the way to fix this issue is by locking the version of @ember/string to 3.1.1.
@MichalBryxi
Copy link
Contributor

For random bypassers:

fix this issue is by locking the version of @ember/string to 3.1.1.

Means:

// package.json
{
  "dependencies": {
    "@ember/string": "^3.1.1",
  },
}

MichalBryxi added a commit to MichalBryxi/ember-cli-addon-docs that referenced this issue Apr 23, 2025
@MichalBryxi
fix: Remove ember-cli-string-helpers
89ce028 
- This pulls @ember/string 3.1.1 into dependent project and that causes a lot of issues
- Since we have `capitalize` in @ember/string, we can just call that in our internal helper
- Also bumped internal version of @ember/string to v4.x

Fixes ember-learn#1666
@MichalBryxi MichalBryxi mentioned this issue Apr 23, 2025
Merged
MichalBryxi added a commit to MichalBryxi/ember-cli-addon-docs that referenced this issue Apr 23, 2025
@MichalBryxi
fix: Remove ember-cli-string-helpers
5aeda19 
- This pulls @ember/string 3.1.1 into dependent project and that causes a lot of issues
- Since we have `capitalize` in @ember/string, we can just call that in our internal helper
- Also bumped internal version of @ember/string to v4.x

Fixes ember-learn#1666
MichalBryxi added a commit to MichalBryxi/ember-cli-addon-docs that referenced this issue May 2, 2025
@MichalBryxi
fix: Remove ember-cli-string-helpers
86909dd 
- This pulls @ember/string 3.1.1 into dependent project and that causes a lot of issues
- Since we have `capitalize` in @ember/string, we can just call that in our internal helper
- Also bumped internal version of @ember/string to v4.x

Fixes ember-learn#1666
MichalBryxi added a commit to MichalBryxi/ember-cli-addon-docs that referenced this issue May 2, 2025
@MichalBryxi
fix: Remove ember-cli-string-helpers
1bd9b1f 
- This pulls @ember/string 3.1.1 into dependent project and that causes a lot of issues
- Since we have `capitalize` in @ember/string, we can just call that in our internal helper
- Also bumped internal version of @ember/string to v4.x

Fixes ember-learn#1666
MichalBryxi added a commit to MichalBryxi/ember-cli-addon-docs that referenced this issue May 3, 2025
@MichalBryxi
fix: Remove ember-cli-string-helpers
916cd86 
- This pulls @ember/string 3.1.1 into dependent project and that causes a lot of issues
- Since we have `capitalize` in @ember/string, we can just call that in our internal helper
- Also bumped internal version of @ember/string to v4.x

Fixes ember-learn#1666
MichalBryxi added a commit to MichalBryxi/ember-cli-addon-docs that referenced this issue May 3, 2025
@MichalBryxi
fix: Bump @ember/string to v4.x
9260297 
- Previously it pulls @ember/string 3.1.1 into dependent project and that causes a lot of issues

Fixes ember-learn#1666
SergeAstapov pushed a commit that referenced this issue May 3, 2025
@MichalBryxi
fix: Remove ember-cli-string-helpers (#1672)
cd2bdc2 
* fix: Remove ember-cli-string-helpers

- This pulls @ember/string 3.1.1 into dependent project and that causes a lot of issues
- Since we have `capitalize` in @ember/string, we can just call that in our internal helper
- Also bumped internal version of @ember/string to v4.x

Fixes #1666

* fix: ember-tether & testing issues

- As per [ember-tether documentation](https://github.com/yapplabs/ember-tether) in testing mode we have to make sure that the portal is attached to correct DOM scope

> Tether works by appending tethered elements to the <body> tag. Unfortunately, this moves your content outside of the Ember application rootElement during acceptance testing. This breaks event dispatch and action handling, including traditional Ember test helpers like click.

This fixes all tests that fail because search popup can't be find.
MichalBryxi added a commit to MichalBryxi/ember-cli-addon-docs that referenced this issue May 4, 2025
@MichalBryxi
fix: Remove ember-cli-string-helpers
96d70c0 
- This pulls @ember/string 3.1.1 into dependent project and that causes a lot of issues
- Since we have `capitalize` in @ember/string, we can just call that in our internal helper
- Also bumped internal version of @ember/string to v4.x

Fixes ember-learn#1666
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Remove ember-cli-string-helpers MichalBryxi/ember-cli-addon-docs
2 participants
@MichalBryxi @barryofguilder