Merge pull request kubernetes#69541 from justinsb/remove_unnecessary_mkdir

k8s-ci-robot · web-flow · commit 1d2e10c7c642 · 2018-10-08T20:55:30.000-07:00
Remove superfluous MkdirAll from MakeTempDirOrDie
diff --git a/test/utils/tmpdir.go b/test/utils/tmpdir.go
@@ -18,7 +18,6 @@ package utils
 
 import (
 	"io/ioutil"
-	"os"
 
 	"github.com/golang/glog"
 )
@@ -31,8 +30,5 @@ func MakeTempDirOrDie(prefix string, baseDir string) string {
 	if err != nil {
 		glog.Fatalf("Can't make a temp rootdir: %v", err)
 	}
-	if err = os.MkdirAll(tempDir, 0750); err != nil {
-		glog.Fatalf("Can't mkdir(%q): %v", tempDir, err)
-	}
 	return tempDir
 }

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,6 @@ package utils`
`18`	`18`
`19`	`19`	`import (`
`20`	`20`	`"io/ioutil"`
`21`		`- "os"`
`22`	`21`
`23`	`22`	`"github.com/golang/glog"`
`24`	`23`	`)`
`@@ -31,8 +30,5 @@ func MakeTempDirOrDie(prefix string, baseDir string) string {`
`31`	`30`	`if err != nil {`
`32`	`31`	`glog.Fatalf("Can't make a temp rootdir: %v", err)`
`33`	`32`	`}`
`34`		`- if err = os.MkdirAll(tempDir, 0750); err != nil {`
`35`		`- glog.Fatalf("Can't mkdir(%q): %v", tempDir, err)`
`36`		`- }`
`37`	`33`	`return tempDir`
`38`	`34`	`}`