Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable usetesting linter #19581

Open
9 tasks done
ivanvc opened this issue Mar 12, 2025 · 3 comments · May be fixed by #19607
Open
9 tasks done

Re-enable usetesting linter #19581

ivanvc opened this issue Mar 12, 2025 · 3 comments · May be fixed by #19607
Assignees
@mmorel-35
Labels
area/tooling priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. stage/triaged type/cleanup

Comments

@ivanvc
Copy link
Member

ivanvc commented Mar 12, 2025 •
edited
Loading

What would you like to be added?

With the Go 1.24 upgrade (#19440), golangci-lint (specifically the usetesting linter) started raising many issues related to new test functions available in Go 1.24.

The changes are more or less:

146 files changed, 1157 insertions(+), 1212 deletions(-)

Because we couldn't solve the issues in Go 1.23 (functions don't exist yet), I disabled the linter. The idea is to create small pull requests that address each one of our submodules.

Completion tracking:

Why is this needed?

To reenable the linter, and help with code quality.
@ivanvc ivanvc added area/tooling priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. type/cleanup labels Mar 12, 2025
@ivanvc
Copy link
Member Author

ivanvc commented Mar 12, 2025

@mmorel-35 are you interested in helping with the rest of the modules?

This was referenced Mar 12, 2025
Merged
Merged
@mmorel-35
Copy link
Contributor

mmorel-35 commented Mar 13, 2025 •
edited
Loading

Yes, I can help, once the two first are merged

@ivanvc
Copy link
Member Author

ivanvc commented Mar 13, 2025

/assign @mmorel-35

This was referenced Mar 13, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmorel-35 mmorel-35

Labels
area/tooling priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. stage/triaged type/cleanup
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tests/integration: address Go 1.24 usetesting issues mmorel-35/etcd
2 participants
@ivanvc @mmorel-35