Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing support for ProgressRequest in gRPC proxy #19710

Open
4 tasks done
alexandrevilain opened this issue Apr 4, 2025 · 0 comments · May be fixed by #19711
Open
4 tasks done

Missing support for ProgressRequest in gRPC proxy #19710

alexandrevilain opened this issue Apr 4, 2025 · 0 comments · May be fixed by #19711
Labels

Comments

@alexandrevilain
Copy link

Bug report criteria

What happened?

When using k8s 1.32 with ETCD gRPC proxy with the watchList feature gate enabled by default.
We get the following error:

{"level":"error","ts":"2025-04-04T12:13:01.411460Z","caller":"grpcproxy/watch.go:276","msg":"not supported request type by gRPC proxy","request":"progress_request:<> ","stacktrace":"go.etcd.io/etcd/server/v3/proxy/grpcproxy.(*watchProxyStream).recvLoop\n\tgo.etcd.io/etcd/server/v3/proxy/grpcproxy/watch.go:276\ngo.etcd.io/etcd/server/v3/proxy/grpcproxy.(*watchProxy).Watch.func1\n\tgo.etcd.io/etcd/server/v3/proxy/grpcproxy/watch.go:129"}

What did you expect to happen?

ETCD gRPC proxy supporting the pb.WatchRequest_ProgressRequest requests.

How can we reproduce it (as minimally and precisely as possible)?

Starting a k8s APIserver using ETCD gRPC proxy endpoint in the --etcd-servers flags.
The APIserver (if < 1.31) should have the watchList feature gate enabled with --feature-gates=kube:WatchList=true

Anything else we need to know?

We're falling in the default case in the watchProxyStream's recvloop method: https://github.com/etcd-io/etcd/blob/main/server/proxy/grpcproxy/watch.go#L274

Etcd version (please run commands below)

$ etcd --version
etcd Version: 3.5.21
Git SHA: a17edfd
Go Version: go1.23.7
Go OS/Arch: linux/amd64

No "version" command available for gRPC proxy.

Etcd configuration (command line flags or environment variables)

N/A

Etcd debug information (please run commands below, feel free to obfuscate the IP address or FQDN in the output)

N/A

Relevant log output

{"level":"error","ts":"2025-04-04T12:13:00.405820Z","caller":"grpcproxy/watch.go:276","msg":"not supported request type by gRPC proxy","request":"progress_request:<> ","stacktrace":"go.etcd.io/etcd/server/v3/proxy/grpcproxy.(*watchProxyStream).recvLoop\n\tgo.etcd.io/etcd/server/v3/proxy/grpcproxy/watch.go:276\ngo.etcd.io/etcd/server/v3/proxy/grpcproxy.(*watchProxy).Watch.func1\n\tgo.etcd.io/etcd/server/v3/proxy/grpcproxy/watch.go:129"}
@alexandrevilain alexandrevilain changed the title Missing support for ProgressRequest in grpcProxy Missing support for ProgressRequest in gRPC proxy Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

1 participant