Skip to content

Commit 740c7eb

Browse files
authored
Round up of a few typo fixes (#15383)
* Fix link to OPCM * Fix typo. * Fix Withdrawals spelling * Fix method name in comment
1 parent 905d48c commit 740c7eb

File tree

4 files changed

+9
-10
lines changed

4 files changed

+9
-10
lines changed

.circleci/config.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -433,7 +433,7 @@ jobs:
433433
type: boolean
434434
default: false
435435
resource_class:
436-
description: Docker resoruce class
436+
description: Docker resource class
437437
type: string
438438
default: medium
439439
machine:

op-e2e/actions/proofs/isthmus_fork_test.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -108,24 +108,24 @@ func testIsthmusActivationAtGenesis(gt *testing.T, testCfg *helpers.TestCfg[any]
108108
env.RunFaultProofProgramFromGenesis(t, safeBlock.Number, testCfg.CheckResult, testCfg.InputParams...)
109109
}
110110

111-
// Test_ProgramAction_IsthmusWithdrawlsRoot tests the withdrawals root in the header:
111+
// Test_ProgramAction_IsthmusWithdrawalsRoot tests the withdrawals root in the header:
112112
// - post canyon but pre Isthmus
113113
// - post Isthmus
114114
// We do not include pre canyon behaviour (nil withdrawals root) since Canyon does not support Cancun L1.
115115
// It does this by activating the relevant forks at genesis.
116116
// It runs the fault proof program.
117-
func Test_ProgramAction_IsthmusWithdrawlsRoot(gt *testing.T) {
117+
func Test_ProgramAction_IsthmusWithdrawalsRoot(gt *testing.T) {
118118
matrix := helpers.NewMatrix[any]()
119119

120120
matrix.AddDefaultTestCases(
121121
nil,
122122
helpers.NewForkMatrix(helpers.Holocene, helpers.Isthmus),
123-
testWithdrawlsRoot,
123+
testWithdrawalsRoot,
124124
)
125125

126126
matrix.Run(gt)
127127
}
128-
func testWithdrawlsRoot(gt *testing.T, testCfg *helpers.TestCfg[any]) {
128+
func testWithdrawalsRoot(gt *testing.T, testCfg *helpers.TestCfg[any]) {
129129
t := actionsHelpers.NewDefaultTesting(gt)
130130
tp := helpers.NewTestParams(func(tp *e2eutils.TestParams) {})
131131
env := helpers.NewL2FaultProofEnv(t, testCfg, tp, helpers.NewBatcherCfg())
@@ -182,7 +182,7 @@ func Test_ProgramAction_WithdrawalsRootBeforeAtAndAfterIsthmus(gt *testing.T) {
182182

183183
isthmusOffset := 2
184184

185-
testWithdrawlsRootIsthmus := func(gt *testing.T, testCfg *helpers.TestCfg[testCase]) {
185+
testWithdrawalsRootIsthmus := func(gt *testing.T, testCfg *helpers.TestCfg[testCase]) {
186186
t := actionsHelpers.NewDefaultTesting(gt)
187187
tp := helpers.NewTestParams(func(tp *e2eutils.TestParams) {})
188188
var setIsthmusTime = func(dc *genesis.DeployConfig) {
@@ -260,7 +260,7 @@ func Test_ProgramAction_WithdrawalsRootBeforeAtAndAfterIsthmus(gt *testing.T) {
260260
test.name,
261261
test,
262262
helpers.NewForkMatrix(helpers.Holocene),
263-
testWithdrawlsRootIsthmus,
263+
testWithdrawalsRootIsthmus,
264264
)
265265
}
266266
matrix.Run(gt)

op-service/txmgr/txmgr.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ func NewSimpleTxManager(name string, l log.Logger, m metrics.TxMetricer, cfg CLI
158158
return NewSimpleTxManagerFromConfig(name, l, m, conf)
159159
}
160160

161-
// NewSimpleTxManager initializes a new SimpleTxManager with the passed Config.
161+
// NewSimpleTxManagerFromConfig initializes a new SimpleTxManager with the passed Config.
162162
func NewSimpleTxManagerFromConfig(name string, l log.Logger, m metrics.TxMetricer, conf *Config) (*SimpleTxManager, error) {
163163
if err := conf.Check(); err != nil {
164164
return nil, fmt.Errorf("invalid config: %w", err)

packages/contracts-bedrock/book/src/policies/versioning.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ Versioning for monorepo releases works as follows:
7777

7878
## Optimism Contracts Manager (OPCM) Versioning
7979

80-
The [OPCM](https://github.com/ethereum-optimism/optimism/blob/main/packages/contracts-bedrock/src/L1/OPContractsManager.sol) is the contract that manages the deployment of all contracts on L1.
80+
The [OPCM](https://github.com/ethereum-optimism/optimism/blob/develop/packages/contracts-bedrock/src/L1/OPContractsManager.sol) is the contract that manages the deployment of all contracts on L1.
8181

8282
The `OPCM` is the source of truth for the contracts that belong in a release, available as on-chain addresses by querying [the `getImplementations` function](https://github.com/ethereum-optimism/optimism/blob/4c8764f0453e141555846d8c9dd2af9edbc1d014/packages/contracts-bedrock/src/L1/OPContractsManager.sol#L1061).
8383

@@ -148,4 +148,3 @@ Now there are two scenarios for the PR that merges the release branch back into
148148
- In practice, this one unlikely to occur when using inheritance for feature development, as specified in [Smart Contract Feature Development](https://github.com/ethereum-optimism/design-docs/blob/main/smart-contract-feature-development.md) architecture. It's more likely that (1) is the case, and we merge the version change into the base contract.
149149

150150
This flow also provides a dedicated branch for each release, making it easy to deploy a patch or bug fix, regardless of other changes that may have occurred on develop since the release.
151-

0 commit comments

Comments
 (0)