pr comments

Author: njgheorghita

src/bin/poll_latest.rs

@@ -82,10 +82,16 @@ impl Details {
         self.success_count + self.failure_count
     }
 
-    fn update_average_time(&mut self, new_time: Duration) {
+    fn report_success(&mut self, new_time: Duration) {
+        self.success_count += 1;
         self.average_time =
             (self.average_time * (self.success_count - 1) + new_time) / self.success_count
     }
+
+    fn report_failure(&mut self) {
+        // don't update average time on failure
+        self.failure_count += 1;
+    }
 }
 
 #[tokio::main]
@@ -159,42 +165,39 @@ async fn audit_block(
     match header_handle.await? {
         Ok(found_time) => {
             let mut metrics = metrics.lock().unwrap();
-            metrics.header.success_count += 1;
             metrics.active_audit_count -= 1;
             let time_diff = found_time - timestamp;
-            metrics.header.update_average_time(time_diff);
+            metrics.header.report_success(time_diff);
         }
         Err(_) => {
             let mut metrics = metrics.lock().unwrap();
             metrics.active_audit_count -= 1;
-            metrics.header.failure_count += 1;
+            metrics.header.report_failure();
         }
     }
     match block_body_handle.await? {
         Ok(found_time) => {
             let mut metrics = metrics.lock().unwrap();
-            metrics.block_body.success_count += 1;
             metrics.active_audit_count -= 1;
             let time_diff = found_time - timestamp;
-            metrics.block_body.update_average_time(time_diff);
+            metrics.block_body.report_success(time_diff);
         }
         Err(_) => {
             let mut metrics = metrics.lock().unwrap();
-            metrics.block_body.failure_count += 1;
+            metrics.block_body.report_failure();
             metrics.active_audit_count -= 1;
         }
     }
     match receipts_handle.await? {
         Ok(found_time) => {
             let mut metrics = metrics.lock().unwrap();
-            metrics.receipts.success_count += 1;
             metrics.active_audit_count -= 1;
             let time_diff = found_time - timestamp;
-            metrics.receipts.update_average_time(time_diff);
+            metrics.receipts.report_success(time_diff);
         }
         Err(_) => {
             let mut metrics = metrics.lock().unwrap();
-            metrics.receipts.failure_count += 1;
+            metrics.receipts.report_failure();
             metrics.active_audit_count -= 1;
         }
     }
@@ -296,17 +299,15 @@ mod test {
     fn test_detail() {
         let mut details = Details::default();
         assert_eq!(details.total_count(), 0);
-        details.success_count += 1;
-        details.update_average_time(Duration::from_secs(1));
+        details.report_success(Duration::from_secs(1));
         assert_eq!(details.total_count(), 1);
         assert_eq!(details.average_time, Duration::from_secs(1));
-        details.failure_count += 1;
+        details.report_failure();
         assert_eq!(details.total_count(), 2);
-        details.success_count += 1;
-        details.update_average_time(Duration::from_secs(3));
+        details.report_success(Duration::from_secs(3));
         assert_eq!(details.total_count(), 3);
         assert_eq!(details.average_time, Duration::from_secs(2));
-        details.failure_count += 1;
+        details.report_failure();
         assert_eq!(details.total_count(), 4);
     }
 }