Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong (Unclear?) property specification in ethers.Log #4960

Open
oswaldoleal opened this issue Mar 11, 2025 · 0 comments
Open

Wrong (Unclear?) property specification in ethers.Log #4960

oswaldoleal opened this issue Mar 11, 2025 · 0 comments
Labels
documentation Documentation related issue.

Comments

@oswaldoleal
Copy link

Suggestion

Inside the provider.Log definition the specifications for the index and transactionIndex properties seem to be swapped.

When in the context of a Log, the transactionIndex property name should refer to the index of a the log's transaction within the block
while the index property should refer to the log's index within a transaction/block.

The implementation is fine, but the documentation being swapped is missleading. Either, the definitions are wrong or the property names are wrong (unclear at the very least)

Images of the documentation

Image

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation related issue.
Projects
None yet
Development

No branches or pull requests

1 participant