fix: add spinner to feed print command (#404)

* fix: remove elipssis on print feed and add spinner

* chore: remove unnecessarry import

* fix: several minor changes on feed pirnt

* fix: validate feed print exception obj

* fix: use an existing file on feed upload unit test

* fix: modified hash resultant in feed print unit test

* test: try modifying hash again

* test: pick different hash

* fix: print feed topic

Co-authored-by: Cafe137 <[email protected]>

Author: luissanchez0305

.gitignore

@@ -19,6 +19,9 @@ coverage
 # node-waf configuration
 .lock-wscript
 
+#babel RC
+.babelrc.js
+
 build
 dist
 

src/command/feed/print.ts

@@ -4,6 +4,8 @@ import { exit } from 'process'
 import { isSimpleWallet, isV3Wallet } from '../../service/identity'
 import { Identity } from '../../service/identity/types'
 import { pickStamp } from '../../service/stamp'
+import { getFieldOrNull } from '../../utils'
+import { createSpinner } from '../../utils/spinner'
 import { createKeyValue } from '../../utils/text'
 import { FeedCommand } from './feed-command'
 
@@ -26,26 +28,39 @@ export class Print extends FeedCommand implements LeafCommand {
     await super.init()
 
     const topic = this.topic || this.bee.makeFeedTopic(this.topicString)
-    this.console.info('Looking up feed topic ' + topic + '...')
-    const addressString = this.address || (await this.getAddressString())
-    const reader = this.bee.makeFeedReader('sequence', topic, addressString)
-    const { reference, feedIndex, feedIndexNext } = await reader.download()
+    const spinner = createSpinner(`Looking up feed topic ${topic}`)
+    spinner.start()
+    try {
+      const addressString = this.address || (await this.getAddressString())
+      const reader = this.bee.makeFeedReader('sequence', topic, addressString)
+      const { reference, feedIndex, feedIndexNext } = await reader.download()
+
+      if (!this.stamp) {
+        spinner.stop()
+        this.stamp = await pickStamp(this.beeDebug, this.console)
+        spinner.start()
+      }
 
-    if (!this.stamp) {
-      this.stamp = await pickStamp(this.beeDebug, this.console)
+      const { reference: manifest } = await this.bee.createFeedManifest(this.stamp, 'sequence', topic, addressString)
+
+      spinner.stop()
+      this.console.verbose(createKeyValue('Chunk Reference', reference))
+      this.console.verbose(createKeyValue('Chunk Reference URL', `${this.bee.url}/bzz/${reference}/`))
+      this.console.verbose(createKeyValue('Feed Index', feedIndex))
+      this.console.verbose(createKeyValue('Next Index', feedIndexNext))
+      this.console.verbose(createKeyValue('Feed Manifest', manifest))
+
+      this.console.quiet(manifest)
+      this.console.log(createKeyValue('Topic', `${topic}`))
+      this.console.log(createKeyValue('Feed Manifest URL', `${this.bee.url}/bzz/${manifest}/`))
+      this.console.log(createKeyValue('Number of Updates', parseInt(feedIndex, 10) + 1))
+    } catch (error) {
+      spinner.stop()
+      const message = getFieldOrNull(error, 'message')
+      throw Error(`Feed topic lookup error: ${message || 'unknown'}`)
+    } finally {
+      spinner.stop()
     }
-
-    const { reference: manifest } = await this.bee.createFeedManifest(this.stamp, 'sequence', topic, addressString)
-
-    this.console.verbose(createKeyValue('Chunk Reference', reference))
-    this.console.verbose(createKeyValue('Chunk Reference URL', `${this.bee.url}/bzz/${reference}/`))
-    this.console.verbose(createKeyValue('Feed Index', feedIndex))
-    this.console.verbose(createKeyValue('Next Index', feedIndexNext))
-    this.console.verbose(createKeyValue('Feed Manifest', manifest))
-
-    this.console.quiet(manifest)
-    this.console.log(createKeyValue('Feed Manifest URL', `${this.bee.url}/bzz/${manifest}/`))
-    this.console.log(createKeyValue('Number of Updates', parseInt(feedIndex, 10) + 1))
   }
 
   private async getAddressString(): Promise<string> {
@@ -80,7 +95,8 @@ export class Print extends FeedCommand implements LeafCommand {
 
       return wallet.address
     } else if (isSimpleWallet(wallet, identityType)) {
-      const ethereumWallet = Wallet.fromPrivateKey(Buffer.from(wallet.privateKey, 'hex'))
+      const privateKey = wallet.privateKey.replace('0x', '')
+      const ethereumWallet = Wallet.fromPrivateKey(Buffer.from(privateKey, 'hex'))
 
       return ethereumWallet.getAddressString()
     } else {

test/quality-of-life/topic.spec.ts

@@ -17,7 +17,7 @@ describeCommand(
         'topic',
         '-P',
         'topic',
-        '.babelrc.js',
+        'test/message.txt',
         ...getStampOption(),
       ])
     })