Release libR-sys to crates.io

[clauswilke]

We should make a new release to crates.io. Anything that needs to be addressed first? Maybe #31?

@yutannihilation Do you want to handle the release? I can add you as an owner on crates.io.

cc @Ilia-Kosenkov

[Ilia-Kosenkov]

I experimented with a script that sets up everything needed for libR-sys compilation on a clean Windows 10 system, so I have now a better understanding of what needs to be done.

I can address #31 within the next day or so if it is ok.

[clauswilke]

Super, thanks!

[yutannihilation]

Sure, I have no experience of publishing a crate, but I think I can handle the release. #67 is nice to have, but not a blocker issue.

Thanks @Ilia-Kosenkov for addressing #31!

[andy-thomason]

We should write up a "how to" in the README.

You can do a dry run at publishing the crate to find errors before committing.

We use the workspace to publish all extendr crates together on the whole. The version
numbers are usually synced.

[clauswilke]

Any new headers to add before the release?

@andy-thomason has suggested Altrep.h: extendr/extendr#231 (comment)

I also think R_ext/GraphicsEngine.h would be useful.

[Ilia-Kosenkov]

https://github.com/Ilia-Kosenkov/libR-sys/tree/readme-windows
Here is my progress so far. Found an issue with the i686 binding generation on a clean system - I am missing some dependency, will resolve it soon.

[clauswilke]

@Ilia-Kosenkov You can probably simplify. I don't think we need to explain to people how to install Visual Studio.

Also, please pay attention to the structure of subsections. The following sentence is part of the Windows subsection but seems to be meant more generally.

Once R and rust are configured, the library can be easily built:

There are a few cases like this.

Finally, I don't think we need --test-threads=1 anymore. Do we need -- --nocapture?

[clauswilke]

I just tried. cargo test is all that is needed, as far as I can tell.

clauswilke ~/github/libR-sys> cargo test
   Compiling libR-sys v0.2.0 (/Users/clauswilke/github/libR-sys)
    Finished test [unoptimized + debuginfo] target(s) in 3.10s
     Running target/debug/deps/libR_sys-b8d4b2aca00e72cd

running 24 tests
test bindgen_test_layout_R_CMethodDef ... ok
test bindgen_test_layout_R_CallMethodDef ... ok
test bindgen_test_layout_R_outpstream_st ... ok
test bindgen_test_layout_Rcomplex ... ok
test bindgen_test_layout___darwin_pthread_handler_rec ... ok
test bindgen_test_layout_R_inpstream_st ... ok
test bindgen_test_layout___double2 ... ok
test bindgen_test_layout___float2 ... ok
test bindgen_test_layout___mbstate_t ... ok
test bindgen_test_layout___sFILE ... ok
test bindgen_test_layout___sbuf ... ok
test bindgen_test_layout___va_list_tag ... ok
test bindgen_test_layout__opaque_pthread_attr_t ... ok
test bindgen_test_layout__opaque_pthread_cond_t ... ok
test bindgen_test_layout__opaque_pthread_condattr_t ... ok
test bindgen_test_layout__opaque_pthread_mutex_t ... ok
test bindgen_test_layout__opaque_pthread_mutexattr_t ... ok
test bindgen_test_layout__opaque_pthread_once_t ... ok
test bindgen_test_layout__opaque_pthread_rwlock_t ... ok
test bindgen_test_layout__opaque_pthread_rwlockattr_t ... ok
test bindgen_test_layout__opaque_pthread_t ... ok
test bindgen_test_layout_exception ... ok
test bindgen_test_layout_structRstart ... ok
[1] 1
test tests::test_eval ... ok

test result: ok. 24 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

   Doc-tests libR-sys

running 1 test
test src/lib.rs - (line 18) ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

[Ilia-Kosenkov]

@clauswilke, I missed these comments, I will fix it in PR in the morning (it's late night where I am).

Also, I suggest to leave Build Tools installation at least under a spoiler, because Rust surprisingly just gives a generic "Install one of the build tools", but there are plenty of workflows and Rust only needs few, and it may be confusing. This step can save gigabytes of downloading and installation for inexperienced developers, especially because we target R developers switching to Rust in their packages, who potentially have never worked with Microsoft stack before.

I see a lot of questions from rust beginners on SO not being able to compile hello world because of missing build tools or "linker.exe".

[clauswilke]

Ok. Just make sure it's clearly structured and not too confusing. It may help to bring Linux and OS X first, since those are simpler. Basically, you'd write:

• Here are the instructions if you have a working cargo installation.
• If you're on Windows and don't know how to get a working cargo installation, here are the steps.

[yutannihilation]

Are there anything else that needs to be done other than some documentation tweaks I included in #73?

[clauswilke]

Not from my side.

[Ilia-Kosenkov]

We modified README two weeks ago so now it is up-to-date. Everything else looks good to me.

[yutannihilation]

Thank you two for confirming! Then I'll merge #73 and publish to crates.io in an hour or so.

Also thanks for the owner invites, I didn't notice that, sorry...

[yutannihilation]

On the dry run, I found this warning. But, since we have some more time until the majority of Rust users migrate to 2021 edition, and it might take a bit of time to think how to fix this, I ignore this for now.

#75

[yutannihilation]

Published now. Thanks for your support!

https://crates.io/crates/libR-sys/0.2.2

[clauswilke]

Super, thanks!

[andy-thomason]

👍