Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: wrong icon for hi directories #1429

Closed
zefr0x opened this issue Mar 23, 2025 · 3 comments · Fixed by #1442
Closed

bug: wrong icon for hi directories #1429

zefr0x opened this issue Mar 23, 2025 · 3 comments · Fixed by #1442
Assignees
Labels
errors Something isn't working

Comments

@zefr0x
Copy link

zefr0x commented Mar 23, 2025

Image

In this example, the hi directory should be a normal one including the Hindi locale files.
This is also seen for /usr/local/share/locale/hi.

This rule is causing its icon to be displayed as a binary type: https://github.com/eza-community/eza/blob/3ad8132f874f66945eca3511491afa85c5f43ebe/src/output/icons.rs#L194C1-L194C571

I don't know in what context this rule is valid. Is it a common directory? Or is it OK to just remove it?

@zefr0x zefr0x added the errors Something isn't working label Mar 23, 2025
@cafkafk
Copy link
Member

cafkafk commented Apr 1, 2025

I don't know what a hi directory actually is... I think we should spend a little time trying to figure out the original intention before just removing it. E.g. looking through the git commit that introduced it if it has any context

@zefr0x
Copy link
Author

zefr0x commented Apr 2, 2025

It is from 680924d.

From a quick research and reading the commit body, I understood that .hi are files not directories, so it might be a mistake that they made their way here. Maybe @MartinFillon can provide more details since he made #761.

Also I found ~/.cabal directory referenced in cabal's docs, which seem to was added in the same commit, but without the dot.

I believe that the mentioned PR needs another review, if I wasn't wrong about the details above.

@MartinFillon
Copy link
Contributor

From a quick research and reading the commit body, I understood that .hi are files not directories, so it might be a mistake that they made their way here. Maybe @MartinFillon can provide more details since he made #761.

It is indeed a mistake on my side, I put the hi bit of code in the wrong array I will fix this shortly as it wont require much code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
errors Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants