upgrade some of our files to pyre-strict

Summary:
Added pyre-strict to some files from the code quality dashboard based on this devmate prompt:

```
Given the following list of files, if it contains the comment `# pyre-unsafe`, replace it with `# pyre-strict`

1.  fbcode/tools/pyre/tools/generate\_taint\_models/tests/test\_functions.py
2.  fbcode/tools/pyre/client/tests/json\_rpc\_test.py
3.  fbcode/tools/pyre/tools/upgrade/tests/errors\_test.py
4.  fbcode/tools/pyre/tools/generate\_taint\_models/tests/get\_class\_sources\_test.py
5.  fbcode/tools/pyre/tools/generate\_taint\_models/tests/get\_graphql\_sources\_test.py
6.  fbcode/tools/pyre/tools/upgrade/commands/tests/pysa\_version\_update\_test.py
7.  fbcode/tools/pyre/scripts/run\_server\_integration\_test.py
8.  fbcode/tools/pyre/tools/upgrade/commands/tests/expand\_target\_coverage\_test.py
9.  fbcode/tools/pyre/facebook/tools/codemods/**tests**/add\_none\_test.py
10.  fbcode/tools/pyre/facebook/client/commands/notify\_update.py
11.  fbcode/tools/pyre/tools/generate\_taint\_models/tests/get\_request\_specific\_data\_test.py
12.  fbcode/tools/pyre/facebook/tools/codemods/**tests**/enum\_annotation\_test.py
13.  fbcode/tools/pyre/tools/upgrade/commands/tests/fixme\_all\_test.py
14.  fbcode/tools/pyre/facebook/pysa/fbcode\_tests/verify\_models\_test/test.py
15.  fbcode/tools/pyre/tools/upgrade/commands/tests/consolidate\_nested\_configurations\_test.py
16.  fbcode/tools/pyre/tools/generate\_taint\_models/tests/get\_dynamic\_graphql\_sources\_test.py
17.  fbcode/tools/pyre/pyre\_extensions/tests/safe\_json\_test.py
18.  fbcode/tools/pyre/facebook/scripts/binary\_version\_manifold\_health\_helper.py
19.  fbcode/tools/pyre/tools/upgrade/filesystem.py
20.  fbcode/tools/pyre/tools/generate\_taint\_models/tests/get\_globals\_test.py
21.  fbcode/tools/pyre/pyre\_extensions/**init**.py
22.  fbcode/tools/pyre/client/tests/terminal\_test.py
23.  fbcode/tools/pyre/facebook/tools/codemods/**tests**/nd\_array\_test.py
24.  fbcode/tools/pyre/facebook/tools/codemods/examples/add\_none\_example.py
25.  fbcode/tools/pyre/tools/upgrade/commands/tests/global\_version\_update\_test.py
26.  fbcode/tools/pyre/tools/upgrade/commands/tests/strict\_default\_test.py
27.  fbcode/tools/pyre/client/commands/tests/statistics\_test.py
28.  fbcode/tools/pyre/pyre\_extensions/tests/basic\_test.py
29.  fbcode/tools/pyre/facebook/tools/migrations/per\_target/repository.py
30.  fbcode/tools/pyre/facebook/client/tests/arguments\_adder\_test.py
31.  fbcode/tools/pyre/tools/generate\_taint\_models/tests/get\_REST\_api\_sources\_test.py
32.  fbcode/tools/pyre/tools/generate\_taint\_models/tests/get\_filtered\_sources\_test.py
33.  fbcode/tools/pyre/tools/upgrade/commands/tests/command\_test.py
34.  fbcode/tools/pyre/client/commands/tests/initialize\_test.py
35.  fbcode/tools/pyre/client/tests/error\_test.py
36.  fbcode/tools/pyre/client/tests/find\_directories\_test.py
37.  fbcode/tools/pyre/pyre\_extensions/type\_variable\_operators.py
38.  fbcode/tools/pyre/tools/generate\_taint\_models/tests/get\_exit\_nodes\_test.py
39.  fbcode/tools/pyre/tools/upgrade/commands/tests/targets\_to\_configuration\_test.py
40.  fbcode/tools/pyre/pyre\_extensions/generic.py
41.  fbcode/tools/pyre/tools/upgrade/tests/upgrade\_test.py
42.  fbcode/tools/pyre/tools/upgrade/commands/tests/fixme\_test.py
43.  fbcode/tools/pyre/tools/upgrade/commands/tests/fix\_configuration\_test.py
44.  fbcode/tools/pyre/facebook/conformance/conformance\_output.py
```

Then, I ran arc pyre check-changed-targets and reverted the ones that had issues with mock.patch. Some files were green without any changes, others required some small manual type annotation additions.

Reviewed By: MaggieMoss

Differential Revision: D74421675

fbshipit-source-id: 81734c932c54c0741f7f33b5e96ef287d001e095

Author: yangdanny97

client/tests/find_directories_test.py

@@ -3,7 +3,7 @@
 # This source code is licensed under the MIT license found in the
 # LICENSE file in the root directory of this source tree.
 
-# pyre-unsafe
+# pyre-strict
 
 import subprocess
 import tempfile
@@ -491,7 +491,7 @@ def test_find_global_and_local_root(self) -> None:
 class FindTypeshedTest(testslide.TestCase):
     def assert_typeshed_roots(
         self, relative_directories: Iterable[str], expected_roots: Iterable[str]
-    ):
+    ) -> None:
         self.maxDiff = None
         with tempfile.TemporaryDirectory() as root:
             root_path = Path(root)

client/tests/json_rpc_test.py

@@ -3,7 +3,7 @@
 # This source code is licensed under the MIT license found in the
 # LICENSE file in the root directory of this source tree.
 
-# pyre-unsafe
+# pyre-strict
 
 import json
 import unittest

client/tests/terminal_test.py

@@ -3,7 +3,7 @@
 # This source code is licensed under the MIT license found in the
 # LICENSE file in the root directory of this source tree.
 
-# pyre-unsafe
+# pyre-strict
 
 import unittest
 from unittest.mock import MagicMock, patch

pyre_extensions/type_variable_operators.py

@@ -3,7 +3,7 @@
 # This source code is licensed under the MIT license found in the
 # LICENSE file in the root directory of this source tree.
 
-# pyre-unsafe
+# pyre-strict
 from typing import Any, Generic, TypeVar
 
 from .generic import GenericMeta

scripts/run_server_integration_test.py

@@ -19,7 +19,7 @@
 ```
 """
 
-# pyre-unsafe
+# pyre-strict
 
 import argparse
 import filecmp
@@ -34,7 +34,7 @@
 from argparse import Namespace
 from contextlib import contextmanager
 from logging import Logger
-from typing import Generator, Optional, Tuple
+from typing import Generator, Iterator, Optional, Tuple
 
 LOG: Logger = logging.getLogger(__name__)
 
@@ -119,15 +119,15 @@ def __init__(
     ) -> None:
         # Parse list of fake commits.
         assert_readable_directory(repository_path)
-        self._base_repository_path = os.path.realpath(repository_path)
+        self._base_repository_path: str = os.path.realpath(repository_path)
         commits_list = os.listdir(self._base_repository_path)
         list.sort(commits_list)
         for commit in commits_list:
             assert_readable_directory(os.path.join(self._base_repository_path, commit))
-        self._commits_list = iter(commits_list)
+        self._commits_list: Iterator[str] = iter(commits_list)
 
         # Move into the temporary repository directory.
-        self._pyre_directory = os.path.join(base_directory, "repository")
+        self._pyre_directory: str = os.path.join(base_directory, "repository")
         os.mkdir(self._pyre_directory)
         os.chdir(self._pyre_directory)
 
@@ -318,7 +318,7 @@ def run_saved_state_test(
 
 
 @contextmanager
-def _watch_directory(source_directory) -> Generator[None, None, None]:
+def _watch_directory(source_directory: str) -> Generator[None, None, None]:
     subprocess.check_call(
         ["watchman", "watch", source_directory],
         stdout=subprocess.DEVNULL,

tools/generate_taint_models/tests/get_REST_api_sources_test.py

@@ -3,7 +3,7 @@
 # This source code is licensed under the MIT license found in the
 # LICENSE file in the root directory of this source tree.
 
-# pyre-unsafe
+# pyre-strict
 
 import unittest
 from unittest.mock import MagicMock

tools/generate_taint_models/tests/get_class_sources_test.py

@@ -3,7 +3,7 @@
 # This source code is licensed under the MIT license found in the
 # LICENSE file in the root directory of this source tree.
 
-# pyre-unsafe
+# pyre-strict
 
 import unittest
 

tools/generate_taint_models/tests/get_exit_nodes_test.py

@@ -3,7 +3,7 @@
 # This source code is licensed under the MIT license found in the
 # LICENSE file in the root directory of this source tree.
 
-# pyre-unsafe
+# pyre-strict
 
 import unittest
 from unittest.mock import MagicMock

tools/generate_taint_models/tests/get_graphql_sources_test.py

@@ -3,15 +3,15 @@
 # This source code is licensed under the MIT license found in the
 # LICENSE file in the root directory of this source tree.
 
-# pyre-unsafe
+# pyre-strict
+
 
-import os  # noqa
 import unittest
-from typing import Callable
 
 from graphql3 import (
     GraphQLBoolean,
     GraphQLField,
+    GraphQLFieldResolver,
     GraphQLID,
     GraphQLNonNull,
     GraphQLObjectType,
@@ -92,13 +92,13 @@ def function_2() -> None:
 )
 
 
-def add_field(type: GraphQLType, name: str, resolve: Callable) -> None:
+def add_field(type: GraphQLType, name: str, resolve: GraphQLFieldResolver | None) -> None:
     # pyre-ignore[16]: Undefined attribute
     type._fields[name] = GraphQLField(GraphQLNonNull(GraphQLID), resolve=resolve)
 
 
 # Indirectly add in an additional resolver, so that
 # 'test_gather_functions_to_model' can verify that that resolver is detected
-IndirectObjectType = add_field(
+IndirectObjectType: None = add_field(
     type=DirectObjectType, name="indirect", resolve=function_2
 )

tools/generate_taint_models/tests/get_request_specific_data_test.py

@@ -3,7 +3,7 @@
 # This source code is licensed under the MIT license found in the
 # LICENSE file in the root directory of this source tree.
 
-# pyre-unsafe
+# pyre-strict
 
 import unittest
 from unittest.mock import MagicMock

tools/upgrade/commands/tests/fixme_test.py

@@ -3,7 +3,7 @@
 # This source code is licensed under the MIT license found in the
 # LICENSE file in the root directory of this source tree.
 
-# pyre-unsafe
+# pyre-strict
 
 import unittest
 from unittest.mock import MagicMock, patch

tools/upgrade/filesystem.py

@@ -3,7 +3,7 @@
 # This source code is licensed under the MIT license found in the
 # LICENSE file in the root directory of this source tree.
 
-# pyre-unsafe
+# pyre-strict
 
 """
 TODO(T132414938) Add a module-level docstring

tools/upgrade/tests/upgrade_test.py

@@ -3,7 +3,7 @@
 # This source code is licensed under the MIT license found in the
 # LICENSE file in the root directory of this source tree.
 
-# pyre-unsafe
+# pyre-strict
 
 import unittest