Skip to content

Commit 6c5838d

Browse files
rubennortefacebook-github-bot
authored andcommitted
Ship fixMountingCoordinatorReportedPendingTransactionsOnAndroid feature flag by default
Summary: Changelog: [internal] This is stable after the last couple of fixes, so we can enable it by default. Enabling this just improves the accuracy of `IntersectionObserver` and the Event Timing API, and we still haven't shipped those to stable. Reviewed By: GijsWeterings Differential Revision: D72561256
1 parent 9b30cdd commit 6c5838d

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsDefaults.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* This source code is licensed under the MIT license found in the
55
* LICENSE file in the root directory of this source tree.
66
*
7-
* @generated SignedSource<<7c6e2d01585686b614664672367e9107>>
7+
* @generated SignedSource<<7f3dba37b181d001a7f90d2e0e7a6452>>
88
*/
99

1010
/**
@@ -77,7 +77,7 @@ public open class ReactNativeFeatureFlagsDefaults : ReactNativeFeatureFlagsProvi
7777

7878
override fun fixMappingOfEventPrioritiesBetweenFabricAndReact(): Boolean = false
7979

80-
override fun fixMountingCoordinatorReportedPendingTransactionsOnAndroid(): Boolean = false
80+
override fun fixMountingCoordinatorReportedPendingTransactionsOnAndroid(): Boolean = true
8181

8282
override fun fuseboxEnabledRelease(): Boolean = false
8383

packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlagsDefaults.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* This source code is licensed under the MIT license found in the
55
* LICENSE file in the root directory of this source tree.
66
*
7-
* @generated SignedSource<<2fc4a56feb9686df603170c2ec8295ab>>
7+
* @generated SignedSource<<d1f0ac93da2872e97ca83926348d1cce>>
88
*/
99

1010
/**
@@ -136,7 +136,7 @@ class ReactNativeFeatureFlagsDefaults : public ReactNativeFeatureFlagsProvider {
136136
}
137137

138138
bool fixMountingCoordinatorReportedPendingTransactionsOnAndroid() override {
139-
return false;
139+
return true;
140140
}
141141

142142
bool fuseboxEnabledRelease() override {

packages/react-native/scripts/featureflags/ReactNativeFeatureFlags.config.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -332,15 +332,15 @@ const definitions: FeatureFlagDefinitions = {
332332
ossReleaseStage: 'none',
333333
},
334334
fixMountingCoordinatorReportedPendingTransactionsOnAndroid: {
335-
defaultValue: false,
335+
defaultValue: true,
336336
metadata: {
337337
dateAdded: '2024-08-27',
338338
description:
339339
'Fixes a limitation on Android where the mounting coordinator would report there are no pending transactions but some of them were actually not processed due to the use of the push model.',
340340
expectedReleaseValue: true,
341341
purpose: 'experimentation',
342342
},
343-
ossReleaseStage: 'none',
343+
ossReleaseStage: 'stable',
344344
},
345345
fuseboxEnabledRelease: {
346346
defaultValue: false,

packages/react-native/src/private/featureflags/ReactNativeFeatureFlags.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* This source code is licensed under the MIT license found in the
55
* LICENSE file in the root directory of this source tree.
66
*
7-
* @generated SignedSource<<90b82671674512dc6bed998c9a1c9a5a>>
7+
* @generated SignedSource<<f20f2f58a3ee800913a15ab63e64f282>>
88
* @flow strict
99
*/
1010

@@ -269,7 +269,7 @@ export const fixMappingOfEventPrioritiesBetweenFabricAndReact: Getter<boolean> =
269269
/**
270270
* Fixes a limitation on Android where the mounting coordinator would report there are no pending transactions but some of them were actually not processed due to the use of the push model.
271271
*/
272-
export const fixMountingCoordinatorReportedPendingTransactionsOnAndroid: Getter<boolean> = createNativeFlagGetter('fixMountingCoordinatorReportedPendingTransactionsOnAndroid', false);
272+
export const fixMountingCoordinatorReportedPendingTransactionsOnAndroid: Getter<boolean> = createNativeFlagGetter('fixMountingCoordinatorReportedPendingTransactionsOnAndroid', true);
273273
/**
274274
* Flag determining if the React Native DevTools (Fusebox) CDP backend should be enabled in release builds. This flag is global and should not be changed across React Host lifetimes.
275275
*/

0 commit comments

Comments
 (0)