Fix onPointerLeave computation by comparing button presses #50402
+57
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: While investigating pointer events, I noticed that all Android views fire `onPointerLeave`/`onPointerEnter` in rapid succession on every button press. This is because Android fires `ACTION_HOVER_EXIT` on every frame before firing `ACTION_DOWN`. The logic in JSPointerDispatcher needed to be updated to account for this. Unfortunately, `ACTION_HOVER_EXIT` events have no means of distinguishing between whether they were driven by the mouse actually leaving the view's bounds or by a button press. Some OS implementations fire this event on the frame just before leaving the view's boundaries while others fire after, so pure X/Y position isn't helpful enough. The button state property on `ACTION_HOVER_EXIT` also never gets set in some OS. To work around this issue, this change posts a callback to the very next frame after receiving `ACTION_HOVER_EXIT`. If no `ACTION_DOWN` event was received in the same frame, it calls all the way through the existing logic. But, if an `ACTION_DOWN` event *is* received, we compare the event timestamps and if they match we don't post `onPointerLeave`. Changelog: [Android][Fixed] - Prevent onPointerLeave from dispatching during button presses Differential Revision: D72078450
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D72078450 |
|
This pull request has been merged in 833ab6f. |
|
This pull request was successfully merged by @Abbondanzo in 833ab6f When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
While investigating pointer events, I noticed that all Android views fire
onPointerLeave/onPointerEnterin rapid succession on every button press. This is because Android firesACTION_HOVER_EXITon every frame before firingACTION_DOWN. The logic in JSPointerDispatcher needed to be updated to account for this.Unfortunately,
ACTION_HOVER_EXITevents have no means of distinguishing between whether they were driven by the mouse actually leaving the view's bounds or by a button press. Some OS implementations fire this event on the frame just before leaving the view's boundaries while others fire after, so pure X/Y position isn't helpful enough. The button state property onACTION_HOVER_EXITalso never gets set in some OS.To work around this issue, this change posts a callback to the very next frame after receiving
ACTION_HOVER_EXIT. If noACTION_DOWNevent was received in the same frame, it calls all the way through the existing logic. But, if anACTION_DOWNevent is received, we compare the event timestamps and if they match we don't postonPointerLeave.Changelog: [Android][Fixed] - Prevent onPointerLeave from dispatching during button presses
Differential Revision: D72078450