Refactor RuntimeSamplingProfileTraceEventSerializer: use smart pointers, split code, add tests #50531
+650
−204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs, split code, add tests Summary: # Changelog: [Internal] This should not have any functional changes, mostly refactoring the previous code, splitting it into smaller methods, better documentation and added tests. Main changes are: 1. We are going to use smart pointers for `ProfileTreeNode` 2. Split single static method into multiple smaller methods of one class, less cognitive load and smaller context window Differential Revision: D72401690
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D72401690 |
|
This pull request has been merged in af50745. |
|
This pull request was successfully merged by @hoxyq in af50745 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
This should not have any functional changes, mostly refactoring the previous code, splitting it into smaller methods, better documentation and added tests.
Main changes are:
ProfileTreeNodeDifferential Revision: D72401690