refactor: FrescoBasedTextInlineImageSpan

[gouravkhunger]

Summary:

I've migrated FrescoBasedTextInlineImageSpan.java to kotlin. Reference #50513.

Changelog:

[ANDROID] [CHANGED] - Refactor class FrescoBasedTextInlineImageSpan from Java to Kotlin.

Test Plan:

Tested the RN tester app with yarn android on both new and old architecture.

[gouravkhunger]

Hi @mateoguzmana, I'm mostly done with the migration but facing some error with the AbstractDraweeControllerBuilder class expecting 4 type arguments. I've tried wildcard types

react-native/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/frescosupport/FrescoBasedReactTextInlineImageSpan.kt

Line 47 in 3d7db8b

private val draweeControllerBuilder: AbstractDraweeControllerBuilder<*, *, ImageRequest, *>,

But this line is erroring out when trying to test with yarn android

react-native/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/frescosupport/FrescoBasedReactTextInlineImageSpan.kt

Line 133 in 3d7db8b

draweeControllerBuilder.setImageRequest(imageRequest)

BUILD FAILED in 4s
error Failed to install the app. Command failed with exit code 1: ./gradlew installHermesDebug -PreactNativeDevServerPort=8081
e: file:///Users/gourav/temp/react-native/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/frescosupport/FrescoBasedReactTextInlineImageSpan.kt:133:53 Argument type mismatch: actual type is 'com.facebook.imagepipeline.request.ImageRequest', but 'CapturedType(*)?' was expected. FAILURE: Build failed with an exception. * What went wrong:
Execution failed for task ':packages:react-native:ReactAndroid:compileDebugKotlin'.
> A failure occurred while executing org.jetbrains.kotlin.compilerRunner.GradleCompilerRunnerWithWorkers$GradleKotlinCompilerWorkAction > Compilation error. See log for more details * Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
> Get more help at https://help.gradle.org. BUILD FAILED in 4s.
info Run CLI with --verbose flag for more details.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

I'm not sure about the usage of that class' types, as the java variant didn't specifically define those. Could you please help a little? Thank you so much!

[mateoguzmana]

Try:

Suggested change

	private val draweeControllerBuilder: AbstractDraweeControllerBuilder<*, *, ImageRequest, *>,
	private val draweeControllerBuilder: AbstractDraweeControllerBuilder<*, ImageRequest, *, *>,

Was a bit tricky to understand as well, but this worked

[gouravkhunger]

Thank you for this! It worked. My bad I was passing ImageRequest as the third param while the class signature expects it to be on the 2nd:

https://github.com/facebook/fresco/blob/b79964050f2bd82c8e6e9bc5a96dcfe61f95ae67/drawee/src/main/java/com/facebook/drawee/controller/AbstractDraweeControllerBuilder.java#L36