Resolve sendIntent call, reject on exception thrown #50538
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D72606918 |
Abbondanzo
force-pushed
the
export-D72606918
branch
from
d3ff62c to
15e61ad
Compare
Abbondanzo
added a commit
to Abbondanzo/react-native
that referenced
this pull request
Apr 8, 2025
Summary: Promises created from `Linking.sendIntent` calls never resolve, leaving them dangling. This change fixes the issue in two spots: 1. By calling promise.resolve directly after the startActivity call 1. By wrapping startActivity in a try/catch so any exceptions thrown are forwarded to the promise as a rejection Changelog: [Android][Fixed] - Ensure Linking.sendIntent promises resolve or reject Reviewed By: NickGerleman Differential Revision: D72606918
Summary: Pull Request resolved: facebook#50538 Promises created from `Linking.sendIntent` calls never resolve, leaving them dangling. This change fixes the issue in two spots: 1. By calling promise.resolve directly after the startActivity call 1. By wrapping startActivity in a try/catch so any exceptions thrown are forwarded to the promise as a rejection Changelog: [Android][Fixed] - Ensure Linking.sendIntent promises resolve or reject Reviewed By: NickGerleman Differential Revision: D72606918
|
This pull request was exported from Phabricator. Differential Revision: D72606918 |
Abbondanzo
force-pushed
the
export-D72606918
branch
from
15e61ad to
2678397
Compare
|
This pull request was successfully merged by @Abbondanzo in 6609ba9 When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been merged in 6609ba9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Promises created from
Linking.sendIntentcalls never resolve, leaving them dangling. This change fixes the issue in two spots:Changelog: [Android][Fixed] - Ensure Linking.sendIntent promises resolve or reject
Differential Revision: D72606918