Language server gets worried when the namespace is same as the class name

[jens1o]

https://github.com/Microsoft/tolerant-php-parser/blob/master/src/Node/Expression.php

[felixfbecker]

yeah, we should suffix namespaces with an extra backslash.

[ADmad]

It too have hit this issue a few times.

It also prevents the "Goto definition" feature from working for the class. For e.g. if I am inside file CounterCacheBehavior and try "Goto definition" on the use Cake\ORM\Behavior; statement, it just scrolls up to namespace Cake\ORM\Behavior; instead of opening the Behavior class.

[felixfbecker]

Wanna do a PR? As said, the fix should be super easy.

[ADmad]

I have never looked into the lang server internals yet :) But if you can give me some pointers I can try and give it a shot.

[felixfbecker]

The Indexer class takes the task of putting definitions into the index, you just need to change append a \ to the namespace identifier.
The DefinitionResolver finds out the FQN for a reference, same thing there.
Tests also need to be adapted.