Only run dsymutil on OSX in debug builds

alexcrichton · alexcrichton · commit 64afa4ea227a · 2013-11-10T13:58:11.000-08:00
When there are no debug symbols generated, then the program just prints an annoying warning otherwise. Closes rust-lang#10198
diff --git a/src/librustc/back/link.rs b/src/librustc/back/link.rs
@@ -956,8 +956,9 @@ pub fn link_binary(sess: Session,
         sess.abort_if_errors();
     }
 
-    // Clean up on Darwin
-    if sess.targ_cfg.os == abi::OsMacos {
+    // On OSX, debuggers needs this utility to get run to do some munging of the
+    // symbols
+    if sess.targ_cfg.os == abi::OsMacos && sess.opts.debuginfo {
         // FIXME (#9639): This needs to handle non-utf8 paths
         run::process_status("dsymutil", [output.as_str().unwrap().to_owned()]);
     }

Original file line number	Diff line number	Diff line change
`@@ -956,8 +956,9 @@ pub fn link_binary(sess: Session,`
`956`	`956`	`sess.abort_if_errors();`
`957`	`957`	`}`
`958`	`958`
`959`		`- // Clean up on Darwin`
`960`		`- if sess.targ_cfg.os == abi::OsMacos {`
	`959`	`+ // On OSX, debuggers needs this utility to get run to do some munging of the`
	`960`	`+ // symbols`
	`961`	`+ if sess.targ_cfg.os == abi::OsMacos && sess.opts.debuginfo {`
`961`	`962`	`// FIXME (#9639): This needs to handle non-utf8 paths`
`962`	`963`	`run::process_status("dsymutil", [output.as_str().unwrap().to_owned()]);`
`963`	`964`	`}`