brush up

Author: 0x5bfa

src/Files.App/Services/Windows/WindowsRecycleBinService.cs

@@ -82,47 +82,64 @@ public bool DeleteAllAsync()
 		/// <inheritdoc/>
 		public unsafe bool RestoreAllAsync()
 		{
-			// Get IShellItem for Recycle Bin
-			var recycleBinFolderId = FOLDERID.FOLDERID_RecycleBinFolder;
-			var shellItemGuid = typeof(IShellItem).GUID;
 			IShellItem* recycleBinFolderShellItem = default;
-			PInvoke.SHGetKnownFolderItem(&recycleBinFolderId, KNOWN_FOLDER_FLAG.KF_FLAG_DEFAULT, HANDLE.Null, &shellItemGuid, (void**)&recycleBinFolderShellItem);
-
-			// Get IEnumShellItems for Recycle Bin
-			Guid enumShellItemGuid = typeof(IEnumShellItems).GUID;
 			IEnumShellItems* enumShellItems = default;
-			var enumItemsBHID = BHID.BHID_EnumItems;
-			recycleBinFolderShellItem->BindToHandler(null, &enumItemsBHID, &enumShellItemGuid, (void**)&enumShellItems);
-
-			// Initialize how to perform the operation
-			PInvoke.CoCreateInstance(typeof(FileOperation).GUID, null, CLSCTX.CLSCTX_LOCAL_SERVER, out IFileOperation* fileOperation);
-			fileOperation->SetOperationFlags(FILEOPERATION_FLAGS.FOF_NO_UI);
-			fileOperation->SetOwnerWindow(new(MainWindow.Instance.WindowHandle));
-
+			IFileOperation* pFileOperation = default;
 			IShellItem* pShellItem = default;
-			while (enumShellItems->Next(1, &pShellItem) == HRESULT.S_OK)
+
+			try
 			{
-				// Get original path
-				pShellItem->QueryInterface(typeof(IShellItem2).GUID, out var pShellItem2Ptr);
-				var pShellItem2 = (IShellItem2*)pShellItem2Ptr;
-				PInvoke.PSGetPropertyKeyFromName("System.Recycle.DeletedFrom", out var originalPathPropertyKey);
-				pShellItem2->GetString(originalPathPropertyKey, out var szOriginalPath);
-
-				// Get IShellItem of the original path
-				PInvoke.SHCreateItemFromParsingName(szOriginalPath.ToString(), null, typeof(IShellItem).GUID, out var pOriginalPathShellItemPtr);
-				var pOriginalPathShellItem = (IShellItem*)pOriginalPathShellItemPtr;
-
-				// Define to move the shell item
-				fileOperation->MoveItem(pShellItem, pOriginalPathShellItem, new PCWSTR(), null);
+				// Get IShellItem for Recycle Bin
+				var recycleBinFolderId = FOLDERID.FOLDERID_RecycleBinFolder;
+				var shellItemGuid = typeof(IShellItem).GUID;
+				PInvoke.SHGetKnownFolderItem(&recycleBinFolderId, KNOWN_FOLDER_FLAG.KF_FLAG_DEFAULT, HANDLE.Null, &shellItemGuid, (void**)&recycleBinFolderShellItem);
+
+				// Get IEnumShellItems for Recycle Bin
+				Guid enumShellItemGuid = typeof(IEnumShellItems).GUID;
+				var enumItemsBHID = BHID.BHID_EnumItems;
+				recycleBinFolderShellItem->BindToHandler(null, &enumItemsBHID, &enumShellItemGuid, (void**)&enumShellItems);
+
+				// Initialize how to perform the operation
+				PInvoke.CoCreateInstance(typeof(FileOperation).GUID, null, CLSCTX.CLSCTX_LOCAL_SERVER, out pFileOperation);
+				pFileOperation->SetOperationFlags(FILEOPERATION_FLAGS.FOF_NO_UI);
+				pFileOperation->SetOwnerWindow(new(MainWindow.Instance.WindowHandle));
+
+				while (enumShellItems->Next(1, &pShellItem) == HRESULT.S_OK)
+				{
+					// Get original path
+					pShellItem->QueryInterface(typeof(IShellItem2).GUID, out var pShellItem2Ptr);
+					var pShellItem2 = (IShellItem2*)pShellItem2Ptr;
+					PInvoke.PSGetPropertyKeyFromName("System.Recycle.DeletedFrom", out var originalPathPropertyKey);
+					pShellItem2->GetString(originalPathPropertyKey, out var szOriginalPath);
+					pShellItem2->Release();
+
+					// Get IShellItem of the original path
+					PInvoke.SHCreateItemFromParsingName(szOriginalPath.ToString(), null, typeof(IShellItem).GUID, out var pOriginalPathShellItemPtr);
+					var pOriginalPathShellItem = (IShellItem*)pOriginalPathShellItemPtr;
+
+					// Define to move the shell item
+					pFileOperation->MoveItem(pShellItem, pOriginalPathShellItem, new PCWSTR(), null);
+				}
+
+				// Perform
+				pFileOperation->PerformOperations();
+
+				// Reset the icon
+				Win32PInvoke.SHUpdateRecycleBinIcon();
+
+				return true;
+			}
+			catch
+			{
+				return false;
+			}
+			finally
+			{
+				recycleBinFolderShellItem->Release();
+				enumShellItems->Release();
+				pFileOperation->Release();
+				pShellItem->Release();
 			}
-
-			// Perform
-			fileOperation->PerformOperations();
-
-			// Reset the icon
-			Win32PInvoke.SHUpdateRecycleBinIcon();
-
-			return true;
 		}
 	}
 }