Code Quality: Switch Storage Provider Status UI APIs to use MemberFunction (#17034)

dongle-the-gadget · web-flow · commit ae7432d2f5b3 · 2025-04-11T10:59:54.000-04:00
diff --git a/src/Files.App.CsWin32/IStorageProviderQuotaUI.cs b/src/Files.App.CsWin32/IStorageProviderQuotaUI.cs
@@ -16,13 +16,13 @@ public unsafe struct IStorageProviderQuotaUI : IComIID
 		[MethodImpl(MethodImplOptions.AggressiveInlining)]
 		public HRESULT GetQuotaTotalInBytes(ulong* value)
 		{
-			return ((delegate* unmanaged[Stdcall]<IStorageProviderQuotaUI*, ulong*, HRESULT>)(lpVtbl[6]))((IStorageProviderQuotaUI*)Unsafe.AsPointer(ref this), value);
+			return (HRESULT)((delegate* unmanaged[MemberFunction]<IStorageProviderQuotaUI*, ulong*, int>)(lpVtbl[6]))((IStorageProviderQuotaUI*)Unsafe.AsPointer(ref this), value);
 		}
 
 		[MethodImpl(MethodImplOptions.AggressiveInlining)]
 		public HRESULT GetQuotaUsedInBytes(ulong* value)
 		{
-			return ((delegate* unmanaged[Stdcall]<IStorageProviderQuotaUI*, ulong*, HRESULT>)(lpVtbl[8]))((IStorageProviderQuotaUI*)Unsafe.AsPointer(ref this), value);
+			return (HRESULT)((delegate* unmanaged[MemberFunction]<IStorageProviderQuotaUI*, ulong*, int>)(lpVtbl[8]))((IStorageProviderQuotaUI*)Unsafe.AsPointer(ref this), value);
 		}
 
 		public static ref readonly Guid Guid
diff --git a/src/Files.App.CsWin32/IStorageProviderStatusUI.cs b/src/Files.App.CsWin32/IStorageProviderStatusUI.cs
@@ -16,7 +16,7 @@ public unsafe struct IStorageProviderStatusUI : IComIID
 		[MethodImpl(MethodImplOptions.AggressiveInlining)]
 		public HRESULT GetQuotaUI(IStorageProviderQuotaUI** result)
 		{
-			return ((delegate* unmanaged[Stdcall]<IStorageProviderStatusUI*, IStorageProviderQuotaUI**, HRESULT>)lpVtbl[14])((IStorageProviderStatusUI*)Unsafe.AsPointer(ref this), result);
+			return (HRESULT)((delegate* unmanaged[MemberFunction]<IStorageProviderStatusUI*, IStorageProviderQuotaUI**, int>)lpVtbl[14])((IStorageProviderStatusUI*)Unsafe.AsPointer(ref this), result);
 		}
 
 		public static ref readonly Guid Guid
diff --git a/src/Files.App.CsWin32/IStorageProviderStatusUISource.cs b/src/Files.App.CsWin32/IStorageProviderStatusUISource.cs
@@ -16,7 +16,7 @@ public unsafe struct IStorageProviderStatusUISource : IComIID
 		[MethodImpl(MethodImplOptions.AggressiveInlining)]
 		public HRESULT GetStatusUI(IStorageProviderStatusUI** result)
 		{
-			return ((delegate* unmanaged[Stdcall]<IStorageProviderStatusUISource*, IStorageProviderStatusUI**, HRESULT>)lpVtbl[6])((IStorageProviderStatusUISource*)Unsafe.AsPointer(ref this), result);
+			return (HRESULT)((delegate* unmanaged[MemberFunction]<IStorageProviderStatusUISource*, IStorageProviderStatusUI**, int>)lpVtbl[6])((IStorageProviderStatusUISource*)Unsafe.AsPointer(ref this), result);
 		}
 
 		public static ref readonly Guid Guid
diff --git a/src/Files.App.CsWin32/IStorageProviderStatusUISourceFactory.cs b/src/Files.App.CsWin32/IStorageProviderStatusUISourceFactory.cs
@@ -16,7 +16,7 @@ public unsafe struct IStorageProviderStatusUISourceFactory : IComIID
 		[MethodImpl(MethodImplOptions.AggressiveInlining)]
 		public HRESULT GetStatusUISource(nint syncRootId, IStorageProviderStatusUISource** result)
 		{
-			return ((delegate* unmanaged[Stdcall]<IStorageProviderStatusUISourceFactory*, nint, IStorageProviderStatusUISource**, HRESULT>)lpVtbl[6])((IStorageProviderStatusUISourceFactory*)Unsafe.AsPointer(ref this), syncRootId, result);
+			return (HRESULT)((delegate* unmanaged[MemberFunction]<IStorageProviderStatusUISourceFactory*, nint, IStorageProviderStatusUISource**, int>)lpVtbl[6])((IStorageProviderStatusUISourceFactory*)Unsafe.AsPointer(ref this), syncRootId, result);
 		}
 
 		public static ref readonly Guid Guid

Original file line number	Diff line number	Diff line change
`@@ -16,13 +16,13 @@ public unsafe struct IStorageProviderQuotaUI : IComIID`
`16`	`16`	`[MethodImpl(MethodImplOptions.AggressiveInlining)]`
`17`	`17`	`public HRESULT GetQuotaTotalInBytes(ulong* value)`
`18`	`18`	`{`
`19`		`- return ((delegate* unmanaged[Stdcall]<IStorageProviderQuotaUI, ulong, HRESULT>)(lpVtbl[6]))((IStorageProviderQuotaUI*)Unsafe.AsPointer(ref this), value);`
	`19`	`+ return (HRESULT)((delegate* unmanaged[MemberFunction]<IStorageProviderQuotaUI, ulong, int>)(lpVtbl[6]))((IStorageProviderQuotaUI*)Unsafe.AsPointer(ref this), value);`
`20`	`20`	`}`
`21`	`21`
`22`	`22`	`[MethodImpl(MethodImplOptions.AggressiveInlining)]`
`23`	`23`	`public HRESULT GetQuotaUsedInBytes(ulong* value)`
`24`	`24`	`{`
`25`		`- return ((delegate* unmanaged[Stdcall]<IStorageProviderQuotaUI, ulong, HRESULT>)(lpVtbl[8]))((IStorageProviderQuotaUI*)Unsafe.AsPointer(ref this), value);`
	`25`	`+ return (HRESULT)((delegate* unmanaged[MemberFunction]<IStorageProviderQuotaUI, ulong, int>)(lpVtbl[8]))((IStorageProviderQuotaUI*)Unsafe.AsPointer(ref this), value);`
`26`	`26`	`}`
`27`	`27`
`28`	`28`	`public static ref readonly Guid Guid`
Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ public unsafe struct IStorageProviderStatusUI : IComIID`
`16`	`16`	`[MethodImpl(MethodImplOptions.AggressiveInlining)]`
`17`	`17`	`public HRESULT GetQuotaUI(IStorageProviderQuotaUI** result)`
`18`	`18`	`{`
`19`		`- return ((delegate* unmanaged[Stdcall]<IStorageProviderStatusUI, IStorageProviderQuotaUI, HRESULT>)lpVtbl[14])((IStorageProviderStatusUI)Unsafe.AsPointer(ref this), result);`
	`19`	`+ return (HRESULT)((delegate* unmanaged[MemberFunction]<IStorageProviderStatusUI, IStorageProviderQuotaUI, int>)lpVtbl[14])((IStorageProviderStatusUI)Unsafe.AsPointer(ref this), result);`
`20`	`20`	`}`
`21`	`21`
`22`	`22`	`public static ref readonly Guid Guid`