Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: OneDrive size is being calculated wrong #10001

Open
ferrariofilippo opened this issue Sep 15, 2022 · 11 comments
Open

Bug: OneDrive size is being calculated wrong #10001

ferrariofilippo opened this issue Sep 15, 2022 · 11 comments
Labels
area - cloud drives Features or bug reports relating to cloud drives area - properties window Features or bug reports for the file permissions page
Milestone

Comments

@ferrariofilippo
Copy link
Contributor

Description

When displaying OneDrive's properties, space free/used/total refers to the disk where the local folder is stored, rather than the actual size of the folder

Steps To Reproduce

  1. Open OneDrive Properties

Steps to fix

  • Fix how OneDrive used space is calculated

Files Version

Version: 2.3.28.0 OS Version: 10.0.22000.978

Windows Version

Windows 11 Home 21H2 22000.856

Relevant Assets/Logs

OneDrive

@Josh65-2201 Josh65-2201 moved this to 🆕 New in Files task board Sep 17, 2022
@Josh65-2201 Josh65-2201 moved this from 🆕 New to 📋 Planning stage in Files task board Sep 18, 2022
@Josh65-2201 Josh65-2201 changed the title Calculated OneDrive size is wrong Bug: Calculated OneDrive size is wrong Sep 18, 2022
@yaira2 yaira2 moved this from 📋 Planning stage to 🔖 Ready to build in Files task board Sep 18, 2022
@yaira2
Copy link
Member

yaira2 commented Sep 18, 2022

Approved

@yaira2 yaira2 changed the title Bug: Calculated OneDrive size is wrong Bug: OneDrive size is being calculated wrong Oct 3, 2022
@cinqmilleans
Copy link
Contributor

Ok I analyze the bug.

@hecksmosis
Copy link
Contributor

So this should be fixed for now by just calculating the local folder size for OneDrive?

@ferrariofilippo
Copy link
Contributor Author

ferrariofilippo commented Jan 8, 2023

That would fix only UsedSpace not TotalSpace

@hecksmosis
Copy link
Contributor

Oh true

@hecksmosis
Copy link
Contributor

Is there a way to get the remote size with code?

@smarquespt
Copy link

FYI this also happens with Mega.

image

@files-community files-community deleted a comment from Josh65-2201 Nov 14, 2023
@files-community files-community deleted a comment from cinqmilleans Nov 14, 2023
@files-community files-community deleted a comment from cinqmilleans Nov 14, 2023
@yaira2 yaira2 added the area - cloud drives Features or bug reports relating to cloud drives label Apr 16, 2024
@0x5bfa 0x5bfa added the area - properties window Features or bug reports for the file permissions page label May 17, 2024
@yaira2 yaira2 removed the bug label Oct 7, 2024
@dongle-the-gadget
Copy link
Contributor

dongle-the-gadget commented Mar 1, 2025

I managed to find how Explorer did it without the need to use the Graph API, and it's possible to implement it for OneDrive. However, from testing in a Windows 10 VM, it will only work for Windows 11, circa 23H2. Would that be an acceptable compromise for the time being?

@yaira2
Copy link
Member

yaira2 commented Mar 2, 2025

it will only work for Windows 11, circa 23H2

Certainly 👍

@yaira2
Copy link
Member

yaira2 commented Mar 10, 2025

Initial support has been added in #16882 (thank you @dongle-the-gadget!). However, we are keeping this issue open so we can track the following:

  • Enable the storage overview in the details pane for OneDrive
  • Support for older versions of Windows

@yaira2 yaira2 added this to the Files v4 milestone Mar 20, 2025
@yaira2
Copy link
Member

yaira2 commented Apr 10, 2025

It doesn't look like we'll be able to support this feature on older versions of Windows, however we can move forward with enabling the storage overview in the Details Pane like we do for other drives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area - cloud drives Features or bug reports relating to cloud drives area - properties window Features or bug reports for the file permissions page
Projects
Status: 🔖 Ready to build
Development

No branches or pull requests

7 participants