Skip to content

Feature: Add RichGlyph to command palette items #14707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
0x5bfa opened this issue Feb 12, 2024 · 6 comments
Closed

Feature: Add RichGlyph to command palette items #14707

0x5bfa opened this issue Feb 12, 2024 · 6 comments
Labels
area - omnibar Features or bug reports relating to the omnibar

Comments

@0x5bfa
Copy link
Member

0x5bfa commented Feb 12, 2024

What feature or improvement do you think would benefit Files?

When we decided to implement command palette we just decided to add RichCommand title to each item. But it’s nice to have icons too.

Requirements

  • Add icon

Files Version

3.2.0

Windows Version

10.22000.0

Comments

No response

@yaira2
Copy link
Member

yaira2 commented Feb 18, 2024

Fyi @hishitetsu

@hishitetsu
Copy link
Member

One idea is to display the default icon for commands for which no icon is provided.
However, I think it would look bad if we don't provide icons for as many commands as possible first.

@0x5bfa 0x5bfa changed the title Feature: Add RichIcon to command palette items Feature: Add RichGlyph to command palette items Feb 21, 2024
@0x5bfa
Copy link
Member Author

0x5bfa commented Feb 21, 2024

I think many actions already have their own icon. @mdtauk I saw your concept that have this feature. What do you think?

@yaira2
Copy link
Member

yaira2 commented Jun 4, 2024

The design is ready
image

@yaira2 yaira2 moved this from 🆕 New to 🔖 Ready to build in Files task board Jun 4, 2024
@yaira2 yaira2 added the area - omnibar Features or bug reports relating to the omnibar label Aug 19, 2024
@yaira2
Copy link
Member

yaira2 commented Apr 1, 2025

This is being addressed with #16029

@yaira2 yaira2 closed this as completed Apr 1, 2025
@github-project-automation github-project-automation bot moved this from 🔖 Ready to build to ✅ Done in Files task board Apr 1, 2025
@mdtauk
Copy link
Contributor

mdtauk commented Apr 1, 2025

I think it is ok to have less common actions without an icon, but the text still being aligned as those with icons. A blank space is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area - omnibar Features or bug reports relating to the omnibar
Projects
Status: Done
Development

No branches or pull requests

4 participants