Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Address bar formatting causes issues when running commands through address bar #15447

Closed
FieryRMS opened this issue May 22, 2024 · 2 comments · Fixed by #15448
Closed

Bug: Address bar formatting causes issues when running commands through address bar #15447

FieryRMS opened this issue May 22, 2024 · 2 comments · Fixed by #15448
Labels
good first issue Good issue for new contributors to get started with

Comments

@FieryRMS
Copy link
Contributor

FieryRMS commented May 22, 2024

Description

Commands run through the address bar are being formatted, which breaks some commands. For example, // and / are converted to \ in the address bar. https://github.com/files-community/Files becomes https:\github.com\files-community\Files. This behavior is inconsistent with how windows explorer or run dialog handles commands.

This can cause issues with many commands that take links/paths/strings as parameters and expect a certain format, like git, curl. For example, running git clone https://github.com/files-community/Files does not work in Files but works in Windows explorer. curl https://httpbin.org/get does not work in Files for the same reason.

Steps To Reproduce

  1. run ping https://github.com/files-community/Files from the address bar. (we are only interested in the output, not if it pings)
  2. Actual output:
    Ping request could not find host https:\github.com\files-community\Files. Please check the name and try again.

Requirements

Expected output:
Ping request could not find host https://github.com/files-community/Files. Please check the name and try again.

This is the behavior in Windows Explorer. More specifically, https://github.com/files-community/Files remains unchanged when passed as a parameter to the command.

Files Version

3.4.1.0

Windows Version

10.0.22631.3593

Log File

(not necessary)

@FieryRMS FieryRMS added the bug label May 22, 2024
@Josh65-2201
Copy link
Member

Thanks for the report, the path bar isn't meant to be used for terminal commands or replace run dialog, at most it opens a program with a path added. We're tracking integrated terminals in #6235 . You can check there or click subscribe in the right sidebar for updates.

@yaira2
Copy link
Member

yaira2 commented May 22, 2024

Thanks for the report, the path bar isn't meant to be used for terminal commands or replace run dialog, at most it opens a program with a path added. We're tracking integrated terminals in #6235 . You can check there or click subscribe in the right sidebar for updates.

@Josh65-2201 the original intention was for the address bar to help launch commands, but it was never a widely advertised feature.

@yaira2 yaira2 reopened this May 22, 2024
@yaira2 yaira2 changed the title Bug: Inconsistent behavior when running commands through address bar Bug: Address bar formatting causes issues when running commands through address bar May 22, 2024
@yaira2 yaira2 added the good first issue Good issue for new contributors to get started with label May 22, 2024
@yaira2 yaira2 moved this from 🆕 New to 🔖 Ready to build in Files task board May 22, 2024
@Josh65-2201 Josh65-2201 moved this from 🔖 Ready to build to 🏗 In progress in Files task board May 22, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Files task board May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good issue for new contributors to get started with
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants