Fix: Fixed errors that occurred with shortcut items in git repositories #17015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcofranzen99
commented
Apr 3, 2025
0x5bfa
approved these changes
Apr 9, 2025
| @@ -48,9 +48,8 @@ public override void GetBaseProperties() | |||
| ViewModel.LoadFileIcon = Item.LoadFileIcon; | |||
| ViewModel.ContainsFilesOrFolders = Item.ContainsFilesOrFolders; | |||
|
|
|||
| if (Item.IsShortcut) | |||
| if (Item.IsShortcut && Item is IShortcutItem shortcutItem) | |||
There was a problem hiding this comment.
I think this is the important part. FYI for others.
yaira2
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
Description
The problem was that GitShortcutItem cannot be cast to ShortcutItem because GitShortcutItem only inherits from GitItem and IShortcutItem. It cannot additionally inherit from ShortcutItem, since a class in C# cannot have multiple base classes.
Simply casting to IShortcutItem everywhere did not work, as the IShortcutItem interface would lack properties of the ListedItem (such as ItemPath).
That's why I decided to create an interface IListedItem. IShortcutItem & IGitItem now both inherit from this interface.
Problems only occurred with shortcut items that are part of a git repository. Not all of them led to a crash, some only displayed error messages or led to incorrect behavior. Here is a list of affected actions:
Steps used to test these changes