fix(firestore-bigquery-change-tracker): keep partition value on delete using old data

Author: CorieW

firestore-bigquery-export/firestore-bigquery-change-tracker/package.json

@@ -5,7 +5,7 @@
     "url": "github.com/firebase/extensions.git",
     "directory": "firestore-bigquery-export/firestore-bigquery-change-tracker"
   },
-  "version": "1.1.41",
+  "version": "1.1.42",
   "description": "Core change-tracker library for Cloud Firestore Collection BigQuery Exports",
   "main": "./lib/index.js",
   "scripts": {

firestore-bigquery-export/firestore-bigquery-change-tracker/src/bigquery/partitioning.ts

@@ -1,13 +1,12 @@
 import { FirestoreBigQueryEventHistoryTrackerConfig } from ".";
-import { FirestoreDocumentChangeEvent } from "..";
+import { ChangeType, FirestoreDocumentChangeEvent } from "..";
 import * as firebase from "firebase-admin";
 
 import * as logs from "../logs";
 import * as bigquery from "@google-cloud/bigquery";
 import * as functions from "firebase-functions";
 import { getNewPartitionField } from "./schema";
 import { BigQuery, TableMetadata } from "@google-cloud/bigquery";
-
 import { PartitionFieldType } from "../types";
 
 export class Partitioning {
@@ -195,11 +194,16 @@ export class Partitioning {
     Delete changes events have no data, return early as cannot partition on empty data.
   **/
   getPartitionValue(event: FirestoreDocumentChangeEvent) {
-    if (!event.data) return {};
+    // When old data is disabled and the operation is delete
+    // the data and old data will be null
+    if (event.data == null && event.oldData == null) return {};
 
     const firestoreFieldName = this.config.timePartitioningFirestoreField;
     const fieldName = this.config.timePartitioningField;
-    const fieldValue = event.data[firestoreFieldName];
+    const fieldValue =
+      event.operation === ChangeType.DELETE
+        ? event.oldData[firestoreFieldName]
+        : event.data[firestoreFieldName];
 
     if (!fieldName || !fieldValue) {
       return {};