Keep artifact registry dry run off for policy changes (#8419)

* fix to unset the boolean cleanupPolicyDryRun on ar repos

* adding changelog

Author: colerogers

CHANGELOG.md

@@ -1 +1,2 @@
 - Fixed an issue in the extensions emulator where parameter default values would not be substitued into resource definitions.
+- Keep artifact registry dry run off for policy changes #8419

src/functions/artifacts.ts

@@ -173,6 +173,7 @@ export async function setCleanupPolicy(
       ...repository.cleanupPolicies,
       ...generateCleanupPolicy(daysToKeep),
     },
+    cleanupPolicyDryRun: false,
     labels,
   };
   await exports.updateRepository(update);

src/gcp/artifactregistry.ts

@@ -23,6 +23,7 @@ export interface Repository {
   createTime: string;
   updateTime: string;
   cleanupPolicies?: Record<string, CleanupPolicy | undefined>;
+  cleanupPolicyDryRun?: boolean;
   labels?: Record<string, string>;
 }
 
@@ -84,7 +85,7 @@ export async function getRepository(repoPath: string): Promise<Repository> {
  * Update an Artifact Registry repository.
  */
 export async function updateRepository(repo: RepositoryInput): Promise<Repository> {
-  const updateMask = proto.fieldMasks(repo, "cleanupPolicies", "labels");
+  const updateMask = proto.fieldMasks(repo, "cleanupPolicies", "cleanupPolicyDryRun", "labels");
   if (updateMask.length === 0) {
     const res = await client.get<Repository>(repo.name!);
     return res.body;