Skip to content

Commit c361b8c

Browse files
authored
tvOS Reference Doc Changes (#583)
Update the reference docs to refer to tvOS when discussing particular methods and classes.
1 parent ffc921e commit c361b8c

File tree

14 files changed

+50
-41
lines changed

14 files changed

+50
-41
lines changed

app/src/AppOptions.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ public void Dispose() { }
7272
/// file or PROJECT_ID in the GoogleService-Info.plist.
7373
public string ProjectId { get; set; }
7474

75-
/// Gets or sets the Android or iOS client project name.
75+
/// Gets or sets the Android, iOS or tvOS client project name.
7676
///
7777
/// This is the project_name in the Android google-services.json config
7878
/// file or BUNDLE_ID in the GoogleService-Info.plist.

app/src/ErrorMessages.cs

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,9 @@ internal class ErrorMessages {
4343
"* Rebuild your APK and deploy.\n";
4444

4545
private static string DEPENDENCY_NOT_FOUND_ERROR_IOS =
46-
"On iOS+ Firebase requires native (C/C++) and Cocoapod components\n" +
47-
"that are distributed with the Firebase SDK and via Cocoapods.\n" +
46+
"On iOS and tvOS Firebase requires native (C/C++) and Cocoapod\n" +
47+
"components that are distributed with the Firebase SDK and via\n" +
48+
"Cocoapods.\n" +
4849
"\n" +
4950
"It's likely that you did not include the require Cocoapod\n" +
5051
"dependencies for Firebase in your Unity project.\n" +
@@ -56,8 +57,8 @@ internal class ErrorMessages {
5657
" iOS Resolver -> Settings'\n" +
5758
"* In the iOS Resolver settings check 'Podfile Generation' and\n" +
5859
" 'Add Cocoapods to Generated Xcode Project'.\n" +
59-
"* Build your iOS project and check the Unity console for any\n" +
60-
" errors associated with Cocoapod tool execution.\n" +
60+
"* Build your iOS or tvOS project and check the Unity console for\n" +
61+
" any errors associated with Cocoapod tool execution.\n" +
6162
" You will need to correctly install Cocoapods tools to generate\n" +
6263
" a working build.\n";
6364

@@ -84,7 +85,7 @@ internal class ErrorMessages {
8485

8586
private static string DLL_NOT_FOUND_ERROR_IOS =
8687
"A Firebase static library (e.g libApp.a) was not linked with your\n" +
87-
"iOS application.\n";
88+
"iOS or tvOS application.\n";
8889

8990
private static string DLL_NOT_FOUND_ERROR_GENERIC =
9091
"A Firebase shared library (.dll / .so) could not be loaded.\n";

app/src/swig/app.i

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -479,7 +479,7 @@ static firebase::AppOptions* AppOptionsLoadFromJsonConfig(const char* config) {
479479
/// @endcode
480480
/// @endif
481481
///
482-
/// or on iOS to your Info.plist:
482+
/// or on iOS or tvOS to your Info.plist:
483483
///
484484
/// @if NOT_DOXYGEN
485485
/// <key>FirebaseDataCollectionDefaultEnabled</key>

app/src/swig/future.i

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -250,7 +250,7 @@ namespace firebase {
250250
%define %SWIG_FUTURE_FOOTER(CSNAME, CSTYPE, CTYPE)
251251
public delegate void Action();
252252

253-
// On iOS, in order to marshal a delegate from C#, it needs both a
253+
// On iOS and tvOS, in order to marshal a delegate from C#, it needs both a
254254
// MonoPInvokeCallback attribute, and be static.
255255
// Because of this need to be static, the instanced callbacks need to be
256256
// saved in a way that can be obtained later, hence the use of a static

auth/src/PhoneAuthProvider.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@ namespace Firebase.Auth {
2323
/// Allows developers to use the phone number and SMS verification codes
2424
/// to authenticate a user.
2525
///
26+
/// This class is not supported on tvOS and Desktop platforms.
27+
///
2628
/// The verification flow results in a Credential that can be used to,
2729
/// * Sign in to an existing phone number account/sign up with a new
2830
/// phone number

auth/src/swig/auth.i

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -473,9 +473,9 @@ static CppInstanceManager<Auth> g_auth_instances;
473473

474474
/// Sign-in a user authenticated via a federated auth provider.
475475
///
476-
/// @note: This operation is supported only on iOS and Android platforms. On
477-
/// non-mobile platforms this method will return a Future with a preset error
478-
/// code: kAuthErrorUnimplemented.
476+
/// @note: This operation is supported only on iOS, tvOS and Android
477+
/// platforms. On other platforms this method will return a Future with a
478+
/// preset error code: kAuthErrorUnimplemented.
479479
public System.Threading.Tasks.Task<SignInResult> SignInWithProviderAsync(
480480
FederatedAuthProvider provider) {
481481
ThrowIfNull();
@@ -1087,9 +1087,9 @@ static CppInstanceManager<Auth> g_auth_instances;
10871087

10881088
/// Reauthenticate a user via a federated auth provider.
10891089
///
1090-
/// @note: This operation is supported only on iOS and Android platforms. On
1091-
/// non-mobile platforms this method will return a Future with a preset error
1092-
/// code: kAuthErrorUnimplemented.
1090+
/// @note: This operation is supported only on iOS, tvOS and Android
1091+
/// platforms. On other platforms this method will return a Future with a
1092+
/// preset error code: kAuthErrorUnimplemented.
10931093
public System.Threading.Tasks.Task<SignInResult>
10941094
ReauthenticateWithProviderAsync(FederatedAuthProvider provider) {
10951095
ThrowIfNull();
@@ -1110,9 +1110,9 @@ static CppInstanceManager<Auth> g_auth_instances;
11101110

11111111
/// Link a user via a federated auth provider.
11121112
///
1113-
/// @note: This operation is supported only on iOS and Android platforms. On
1114-
/// non-mobile platforms this method will return a Future with a preset error
1115-
/// code: kAuthErrorUnimplemented.
1113+
/// @note: This operation is supported only on iOS, tvOS and Android
1114+
/// platforms. On other platforms this method will return a Future with a
1115+
/// preset error code: kAuthErrorUnimplemented.
11161116
public System.Threading.Tasks.Task<SignInResult> LinkWithProviderAsync(
11171117
FederatedAuthProvider provider) {
11181118
ThrowIfNull();

crashlytics/src/IOSImpl.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ internal struct Frame
3434
}
3535

3636

37-
// Stub implementation that is not used on iOS.
37+
// Stub implementation that is not used on iOS or tvOS.
3838
internal class AndroidImpl : Impl {}
3939

4040
//TODO(b/112043008): These extern symbols aren't available for Android builds.

crashlytics/src/Metadata.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ namespace Firebase.Crashlytics {
2222
/// Represents the Unity-specific metadata object that is transformed into JSON.
2323
///
2424
/// Metadata keys are acronyms to save space as there are limits to the maximum size of Keys in
25-
/// the Android and iOS SDK.
25+
/// the Android, iOS and tvOS SDKs.
2626
/// </summary>
2727
internal class Metadata {
2828
// unityVersion: Version of Unity Engine

crashlytics/testapp/Assets/Firebase/Sample/Crashlytics/UIHandler.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,8 @@ void InitializeFirebase() {
6363
// End our session when the program exits.
6464
void OnDestroy() { }
6565

66-
// Causes an error that will crash the app at the platform level (Android or iOS)
66+
// Causes an error that will crash the app at the platform level (Android,
67+
// iOS or tvOS)
6768
public void ThrowUncaughtException() {
6869
DebugLog("Causing a platform crash.");
6970
throw new InvalidOperationException("Uncaught exception created from UI.");

database/src/Query.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -351,7 +351,7 @@ public Query EqualTo(bool value) {
351351
/// Create a query constrained to only return the child node with the given key and value.
352352
/// Note that there is at most one such child as names are unique. <br />
353353
/// <br />
354-
/// <b>Known issue</b> This currently does not work properly on iOS. Please use
354+
/// <b>Known issue</b> This currently does not work properly on iOS and tvOS. Please use
355355
/// EqualTo(string value) instead.
356356
/// </remarks>
357357
/// <param name="value">The value to query for</param>
@@ -368,7 +368,7 @@ public Query EqualTo(string value, string key) {
368368
/// Create a query constrained to only return the child node with the given key and value.
369369
/// Note that there is at most one such child as keys are unique. <br />
370370
/// <br />
371-
/// <b>Known issue</b> This currently does not work properly on iOS. Please use
371+
/// <b>Known issue</b> This currently does not work properly on iOS and tvOS. Please use
372372
/// EqualTo(double value) instead.
373373
/// </remarks>
374374
/// <param name="value">The value to query for</param>
@@ -385,7 +385,7 @@ public Query EqualTo(double value, string key) {
385385
/// Create a query constrained to only return the child node with the given key and value.
386386
/// Note that there is at most one such child as keys are unique. <br />
387387
/// <br />
388-
/// <b>Known issue</b> This currently does not work properly on iOS. Please use
388+
/// <b>Known issue</b> This currently does not work properly on iOS and tvOS. Please use
389389
/// EqualTo(bool value) instead.
390390
/// </remarks>
391391
/// <param name="value">The value to query for</param>

docs/readme.md

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,9 @@ Firebase Unity SDK
22
==================
33

44
The Firebase Unity SDK provides Unity packages for the following Firebase
5-
features on *iOS* and *Android*:
5+
features on *iOS*, *tvOS* and *Android*.
6+
7+
Note: Firebase Dynamic Links is not supported on tvOS.
68

79
| Feature | Unity Package |
810
|:----------------------------------:|:---------------------------------:|
@@ -67,8 +69,11 @@ Support
6769

6870
Release Notes
6971
-------------
70-
### Upcoming Release
72+
### 10.4.0
7173
- Changes
74+
- Firebase introduces Unity SDK support for tvOS, for Analytics,
75+
Authentication, Crashlytics, Database, Firestore, Cloud Functions,
76+
Installations, Messaging, Remote Config and Storage.
7277
- Analytics: Added `SetConsent()` and `GetSessionIdAsync()` APIs.
7378
- Crashlytics: Added `ReportUncaughtExceptionsAsFatal` property and `LogExceptionAsFatal` API.
7479

firestore/src/swig/firestore.i

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -159,8 +159,8 @@ static void SWIG_CSharpSetPendingExceptionFirestore(const char* msg) {
159159
// Important: `invalid_argument` is a subclass of `logic_error` -- make sure
160160
// they are checked in order from most to least derived.
161161
//
162-
// The catch-all clause is to work around iOS issues where some exception types
163-
// aren't getting caught correctly.
162+
// The catch-all clause is to work around iOS and tvOS issues where some
163+
// exception types aren't getting caught correctly.
164164
%exception {
165165
try {
166166
$action

installations/src/swig/installations.i

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ static CppInstanceManager<Installations> g_installations_instances;
151151
/// `Installations` if required.
152152
///
153153
/// @param[in] app The `App` to create an `Installations` object from. On
154-
/// **iOS** this must be the default Firebase `App`.
154+
/// **iOS and tvOS** this must be the default Firebase `App`.
155155
///
156156
/// @returns Installations object if successful, null otherwise.
157157
public static FirebaseInstallations GetInstance(FirebaseApp app) {

messaging/src/swig/messaging.i

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -412,7 +412,7 @@ void* NotificationCopyAndroidNotificationParams(void* notification) {
412412
/// If this setting is enabled, it triggers the token registration refresh
413413
/// immediately. This setting is persisted across app restarts and overrides
414414
/// the setting "firebase_messaging_auto_init_enabled" specified in your
415-
/// Android manifest (on Android) or Info.plist (on iOS).
415+
/// Android manifest (on Android) or Info.plist (on iOS and tvOS).
416416
///
417417
/// <p>By default, token registration during initialization is enabled.
418418
///
@@ -431,7 +431,7 @@ void* NotificationCopyAndroidNotificationParams(void* notification) {
431431
/// @endcode
432432
/// @endif
433433
///
434-
/// or on iOS to your Info.plist:
434+
/// or on iOS or tvOS to your Info.plist:
435435
///
436436
/// @if NOT_DOXYGEN
437437
/// <key>FirebaseMessagingAutoInitEnabled</key>
@@ -847,8 +847,8 @@ void* NotificationCopyAndroidNotificationParams(void* notification) {
847847
// The following docs are all here instead of the header due to b/35780150.
848848

849849
%csmethodmodifiers firebase::messaging::Notification::title "
850-
/// Indicates notification title. This field is not visible on iOS phones
851-
/// and tablets.
850+
/// Indicates notification title. This field is not visible on tvOS, iOS
851+
/// phones and tablets.
852852
public"
853853

854854
%csmethodmodifiers firebase::messaging::Notification::body "
@@ -865,13 +865,13 @@ void* NotificationCopyAndroidNotificationParams(void* notification) {
865865
/// Supports default, or the filename of a sound resource bundled in the
866866
/// app.
867867
///
868-
/// Android sound files must reside in /res/raw/, while iOS sound files
869-
/// can be in the main bundle of the client app or in the Library/Sounds
870-
/// folder of the app’s data container.
868+
/// Android sound files must reside in /res/raw/, while tvOS and iOS sound
869+
/// files can be in the main bundle of the client app or in the
870+
/// Library/Sounds folder of the app’s data container.
871871
public"
872872

873873
%csmethodmodifiers firebase::messaging::Notification::badge "
874-
/// Indicates the badge on the client app home icon. iOS only.
874+
/// Indicates the badge on the client app home icon. iOS and tvOS only.
875875
public"
876876

877877
%csmethodmodifiers firebase::messaging::Notification::tag "
@@ -892,13 +892,13 @@ void* NotificationCopyAndroidNotificationParams(void* notification) {
892892
/// On Android, if this is set, an activity with a matching intent filter is
893893
/// launched when user clicks the notification.
894894
///
895-
/// If set on iOS, corresponds to category in APNS payload.
895+
/// If set on iOS or tvOS, corresponds to category in APNS payload.
896896
public"
897897

898898
%csmethodmodifiers firebase::messaging::Notification::body_loc_key "
899899
/// Indicates the key to the body string for localization.
900900
///
901-
/// On iOS, this corresponds to \"loc-key\" in APNS payload.
901+
/// On iOS and tvOS, this corresponds to \"loc-key\" in APNS payload.
902902
///
903903
/// On Android, use the key in the app's string resources when populating this
904904
/// value.
@@ -908,7 +908,7 @@ void* NotificationCopyAndroidNotificationParams(void* notification) {
908908
/// Indicates the string value to replace format specifiers in body string
909909
/// for localization.
910910
///
911-
/// On iOS, this corresponds to \"loc-args\" in APNS payload.
911+
/// On iOS and tvOS, this corresponds to \"loc-args\" in APNS payload.
912912
///
913913
/// On Android, these are the format arguments for the string resource. For
914914
/// more information, see [Formatting strings][1].
@@ -920,7 +920,7 @@ void* NotificationCopyAndroidNotificationParams(void* notification) {
920920
%csmethodmodifiers firebase::messaging::Notification::title_loc_key "
921921
/// Indicates the key to the title string for localization.
922922
///
923-
/// On iOS, this corresponds to \"title-loc-key\" in APNS payload.
923+
/// On iOS and tvOS, this corresponds to \"title-loc-key\" in APNS payload.
924924
///
925925
/// On Android, use the key in the app's string resources when populating this
926926
/// value.
@@ -930,7 +930,7 @@ void* NotificationCopyAndroidNotificationParams(void* notification) {
930930
/// Indicates the string value to replace format specifiers in title string
931931
/// for localization.
932932
///
933-
/// On iOS, this corresponds to \"title-loc-args\" in APNS payload.
933+
/// On iOS and tvOS, this corresponds to \"title-loc-args\" in APNS payload.
934934
///
935935
/// On Android, these are the format arguments for the string resource. For
936936
/// more information, see [Formatting strings][1].

0 commit comments

Comments
 (0)