Skip to content

Commit 7c4687f

Browse files
committed
chore: run mdformat
This commit was created by running `mdformat .` in the repository root. Signed-off-by: Patrick Roy <[email protected]>
1 parent a7c0457 commit 7c4687f

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

59 files changed

+3120
-3161
lines changed

.github/ISSUE_TEMPLATE/bug_report.md

+4-8
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
11
---
22
name: Bug report
33
about: Create a report to help us improve
4-
title: "[Bug] Title"
4+
title: '[Bug] Title'
55
labels: 'Quality: Bug'
66
assignees: ''
7-
87
---
98

109
# Describe the bug
@@ -14,8 +13,7 @@ assignees: ''
1413
## To Reproduce
1514

1615
`[Author TODO: Steps to reproduce the behaviour:]`
17-
`[ 1. Start Firecracker via....]`
18-
`[ 2. Configure Firecracker via....]`
16+
`[ 1. Start Firecracker via....]` `[ 2. Configure Firecracker via....]`
1917
`[ 3. ....]`
2018

2119
## Expected behaviour
@@ -25,10 +23,8 @@ assignees: ''
2523
## Environment
2624

2725
`[Author TODO: Please supply the following information):]`
28-
`[ - Firecracker version.]`
29-
`[ - Host and guest kernel versions.]`
30-
`[ - Rootfs used.]`
31-
`[ - Architecture.]`
26+
`[ - Firecracker version.]` `[ - Host and guest kernel versions.]`
27+
`[ - Rootfs used.]` `[ - Architecture.]`
3228
`[ - Any other relevant software versions.]`
3329

3430
## Additional context

.github/ISSUE_TEMPLATE/feature_request.md

+4-8
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,22 @@
11
---
22
name: Feature request
33
about: Suggest an idea for this project
4-
title: "[Feature Request] Title"
4+
title: '[Feature Request] Title'
55
labels: ''
66
assignees: ''
7-
87
---
98

109
# Feature Request
1110

12-
`[Author TODO: Why is this feature request important? What are the use cases?
13-
Please describe.]`
11+
`[Author TODO: Why is this feature request important? What are the use cases? Please describe.]`
1412

1513
## Describe the desired solution
1614

17-
`[Author TODO: A clear and concise description of how you would like
18-
the feature to work.]`
15+
`[Author TODO: A clear and concise description of how you would like the feature to work.]`
1916

2017
## Describe possible alternatives
2118

22-
`[Author TODO: A clear and concise description of any alternative solutions
23-
or features you have considered.]`
19+
`[Author TODO: A clear and concise description of any alternative solutions or features you have considered.]`
2420

2521
`[Author TODO: How do you work around not having this feature?]`
2622

.github/pull_request_template.md

+7-5
Original file line numberDiff line numberDiff line change
@@ -9,22 +9,24 @@
99
## License Acceptance
1010

1111
By submitting this pull request, I confirm that my contribution is made under
12-
the terms of the Apache 2.0 license. For more information on following
13-
Developer Certificate of Origin and signing off your commits, please check
12+
the terms of the Apache 2.0 license. For more information on following Developer
13+
Certificate of Origin and signing off your commits, please check
1414
[`CONTRIBUTING.md`][3].
1515

1616
## PR Checklist
1717

1818
- [ ] If a specific issue led to this PR, this PR closes the issue.
1919
- [ ] The description of changes is clear and encompassing.
20-
- [ ] Any required documentation changes (code and docs) are included in this PR.
20+
- [ ] Any required documentation changes (code and docs) are included in this
21+
PR.
2122
- [ ] API changes follow the [Runbook for Firecracker API changes][2].
2223
- [ ] User-facing changes are mentioned in `CHANGELOG.md`.
2324
- [ ] All added/changed functionality is tested.
2425
- [ ] New `TODO`s link to an issue.
25-
- [ ] Commits meet [contribution quality standards](https://github.com/firecracker-microvm/firecracker/blob/main/CONTRIBUTING.md#contribution-quality-standards).
26+
- [ ] Commits meet
27+
[contribution quality standards](https://github.com/firecracker-microvm/firecracker/blob/main/CONTRIBUTING.md#contribution-quality-standards).
2628

27-
---
29+
______________________________________________________________________
2830

2931
- [ ] This functionality cannot be added in [`rust-vmm`][1].
3032

CHANGELOG.md

+372-376
Large diffs are not rendered by default.

CHARTER.md

+19-21
Original file line numberDiff line numberDiff line change
@@ -2,35 +2,33 @@
22

33
## Mission
44

5-
Our mission is to enable secure, multi-tenant, minimal-overhead
6-
execution of container and function workloads.
5+
Our mission is to enable secure, multi-tenant, minimal-overhead execution of
6+
container and function workloads.
77

88
## Tenets (unless you know better ones)
99

1010
These tenets guide Firecracker's development:
1111

12-
1. **Built-In Security**: We provide compute security barriers that
13-
enable multi-tenant workloads, and cannot be mistakenly disabled by
14-
customers. Customer workloads are simultaneously considered sacred
15-
(shall not be touched) and malicious (shall be defended against).
16-
We continuously invest in defense in depth and maintain mechanisms
17-
that ensure security best practices.
18-
1. **Light-Weight Virtualization**: We prioritize measuring
19-
Firecracker's hardware overhead in the dimensions that are important
20-
for our customers, and we strive to make this overhead negligible.
21-
1. **Minimalist in Features**: If it's not clearly required for our
22-
mission, we won't build it. We maintain a single implementation per
23-
capability, and deprecate obsolete implementations; resolving
24-
exceptions is a high priority issue.
25-
1. **Compute Oversubscription**: All of the hardware compute resources
26-
exposed by Firecracker to guests can be securely oversubscribed.
12+
1. **Built-In Security**: We provide compute security barriers that enable
13+
multi-tenant workloads, and cannot be mistakenly disabled by customers.
14+
Customer workloads are simultaneously considered sacred (shall not be
15+
touched) and malicious (shall be defended against). We continuously invest in
16+
defense in depth and maintain mechanisms that ensure security best practices.
17+
1. **Light-Weight Virtualization**: We prioritize measuring Firecracker's
18+
hardware overhead in the dimensions that are important for our customers, and
19+
we strive to make this overhead negligible.
20+
1. **Minimalist in Features**: If it's not clearly required for our mission, we
21+
won't build it. We maintain a single implementation per capability, and
22+
deprecate obsolete implementations; resolving exceptions is a high priority
23+
issue.
24+
1. **Compute Oversubscription**: All of the hardware compute resources exposed
25+
by Firecracker to guests can be securely oversubscribed.
2726

2827
## Contributions & Project Roles
2928

3029
All contributions must align with this charter and follow Firecracker's
3130
[contribution process](CONTRIBUTING.md).
3231

33-
Firecracker [maintainers](MAINTAINERS.md) merge contributions into the
34-
main branch and create Firecracker releases. Maintainers are also
35-
subject to the mission and tenets outlined above. Anyone may submit
36-
and review contributions.
32+
Firecracker [maintainers](MAINTAINERS.md) merge contributions into the main
33+
branch and create Firecracker releases. Maintainers are also subject to the
34+
mission and tenets outlined above. Anyone may submit and review contributions.

CODE_OF_CONDUCT.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
# Code of Conduct
22

33
This project has adopted the
4-
[Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
5-
For more information see the
4+
[Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct). For
5+
more information see the
66
[Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact
77
88
with any additional questions or comments.

CONTRIBUTING.md

+35-24
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,9 @@ you want to merge your changes to Firecracker:
3333
1. Add two reviewers to your pull request (a maintainer will do that for you if
3434
you're new). Work with your reviewers to address any comments and obtain a
3535
minimum of 2 approvals, at least one of which must be provided by
36-
[a maintainer](MAINTAINERS.md).
37-
To update your pull request amend existing commits whenever applicable and
38-
then push the new changes to your pull request branch.
36+
[a maintainer](MAINTAINERS.md). To update your pull request amend existing
37+
commits whenever applicable and then push the new changes to your pull
38+
request branch.
3939
1. Once the pull request is approved, one of the maintainers will merge it.
4040

4141
## Request for Comments
@@ -68,14 +68,20 @@ rusty-hook init
6868
Your contribution needs to meet the following standards:
6969

7070
- Separate each **logical change** into its own commit.
71+
7172
- Each commit must pass all unit & code style tests, and the full pull request
7273
must pass all integration tests. See [tests/README.md](tests/README.md) for
7374
information on how to run tests.
75+
7476
- Unit test coverage must _increase_ the overall project code coverage.
77+
7578
- Include integration tests for any new functionality in your pull request.
79+
7680
- Document all your public functions.
81+
7782
- Add a descriptive message for each commit. Follow
7883
[commit message best practices](https://github.com/erlang/otp/wiki/writing-good-commit-messages).
84+
7985
- A good commit message may look like
8086

8187
```
@@ -87,19 +93,19 @@ Your contribution needs to meet the following standards:
8793
Co-authored-by: <B full name> <B email>
8894
```
8995

90-
- **Usage of `unsafe` is heavily discouraged**. If `unsafe` is required,
91-
it should be accompanied by a comment detailing its...
96+
- **Usage of `unsafe` is heavily discouraged**. If `unsafe` is required, it
97+
should be accompanied by a comment detailing its...
98+
9299
- Justification, potentially including quantifiable reasons why safe
93100
alternatives were not used (e.g. via a benchmark showing a valuable[^1]
94101
performance improvements).
95-
- Safety, as per [`clippy::undocumented_unsafe_blocks`](https://rust-lang.github.io/rust-clippy/master/#undocumented_unsafe_blocks).
96-
This comment must list all invariants of the called function, and
97-
explain why there are upheld. If relevant, it must also prove that
102+
- Safety, as per
103+
[`clippy::undocumented_unsafe_blocks`](https://rust-lang.github.io/rust-clippy/master/#undocumented_unsafe_blocks).
104+
This comment must list all invariants of the called function, and explain
105+
why there are upheld. If relevant, it must also prove that
98106
[undefined behavior](https://doc.rust-lang.org/reference/behavior-considered-undefined.html)
99107
is not possible.
100108

101-
[^1]: Performance improvements in non-hot paths are unlikely to be considered valuable.
102-
103109
E.g.
104110

105111
```rust
@@ -113,24 +119,26 @@ Your contribution needs to meet the following standards:
113119
}
114120
```
115121

116-
- Document your pull requests. Include the reasoning behind each change, and
117-
the testing done.
122+
- Document your pull requests. Include the reasoning behind each change, and the
123+
testing done.
124+
118125
- Acknowledge Firecracker's [Apache 2.0 license](LICENSE) and certify that no
119126
part of your contribution contravenes this license by signing off on all your
120127
commits with `git -s`. Ensure that every file in your pull request has a
121128
header referring to the repository license file.
122129

123130
## Developer Certificate of Origin
124131

125-
Firecracker is an open source product released under the [Apache 2.0 license](LICENSE).
132+
Firecracker is an open source product released under the
133+
[Apache 2.0 license](LICENSE).
126134

127135
We respect intellectual property rights of others and we want to make sure all
128-
incoming contributions are correctly attributed and licensed.
129-
A Developer Certificate of Origin (DCO) is a lightweight mechanism to do that.
136+
incoming contributions are correctly attributed and licensed. A Developer
137+
Certificate of Origin (DCO) is a lightweight mechanism to do that.
130138

131-
The DCO is a declaration attached to every contribution made by every
132-
developer. In the commit message of the contribution, the developer simply adds
133-
a `Signed-off-by` statement and thereby agrees to the DCO, which you can find
139+
The DCO is a declaration attached to every contribution made by every developer.
140+
In the commit message of the contribution, the developer simply adds a
141+
`Signed-off-by` statement and thereby agrees to the DCO, which you can find
134142
below or at DeveloperCertificate.org (<http://developercertificate.org/>).
135143

136144
```
@@ -167,16 +175,19 @@ Certificate of Origin. DCO checks are enabled via <https://github.com/apps/dco>,
167175
and your PR will fail CI without it.
168176

169177
Additionally, we kindly ask you to use your real name. We do not accept
170-
anonymous contributors, nor those utilizing pseudonyms.
171-
Each commit must include a DCO which looks like this:
178+
anonymous contributors, nor those utilizing pseudonyms. Each commit must include
179+
a DCO which looks like this:
172180

173181
```
174182
Signed-off-by: Jane Smith <[email protected]>
175183
```
176184

177-
You may type this line on your own when writing your commit messages.
178-
However, if your `user.name` and `user.email` are set in your git config,
179-
you can use `-s` or `--signoff` to add the `Signed-off-by` line to the end of
180-
the commit message automatically.
185+
You may type this line on your own when writing your commit messages. However,
186+
if your `user.name` and `user.email` are set in your git config, you can use
187+
`-s` or `--signoff` to add the `Signed-off-by` line to the end of the commit
188+
message automatically.
181189

182190
Forgot to add DCO to a commit? Amend it with `git commit --amend -s`.
191+
192+
[^1]: Performance improvements in non-hot paths are unlikely to be considered
193+
valuable.

0 commit comments

Comments
 (0)