@@ -33,9 +33,9 @@ you want to merge your changes to Firecracker:
33
33
1 . Add two reviewers to your pull request (a maintainer will do that for you if
34
34
you're new). Work with your reviewers to address any comments and obtain a
35
35
minimum of 2 approvals, at least one of which must be provided by
36
- [ a maintainer] ( MAINTAINERS.md ) .
37
- To update your pull request amend existing commits whenever applicable and
38
- then push the new changes to your pull request branch.
36
+ [ a maintainer] ( MAINTAINERS.md ) . To update your pull request amend existing
37
+ commits whenever applicable and then push the new changes to your pull
38
+ request branch.
39
39
1 . Once the pull request is approved, one of the maintainers will merge it.
40
40
41
41
## Request for Comments
@@ -68,14 +68,20 @@ rusty-hook init
68
68
Your contribution needs to meet the following standards:
69
69
70
70
- Separate each ** logical change** into its own commit.
71
+
71
72
- Each commit must pass all unit & code style tests, and the full pull request
72
73
must pass all integration tests. See [ tests/README.md] ( tests/README.md ) for
73
74
information on how to run tests.
75
+
74
76
- Unit test coverage must _ increase_ the overall project code coverage.
77
+
75
78
- Include integration tests for any new functionality in your pull request.
79
+
76
80
- Document all your public functions.
81
+
77
82
- Add a descriptive message for each commit. Follow
78
83
[ commit message best practices] ( https://github.com/erlang/otp/wiki/writing-good-commit-messages ) .
84
+
79
85
- A good commit message may look like
80
86
81
87
```
@@ -87,19 +93,19 @@ Your contribution needs to meet the following standards:
87
93
Co-authored-by: <B full name> <B email>
88
94
```
89
95
90
- - ** Usage of ` unsafe ` is heavily discouraged** . If ` unsafe ` is required,
91
- it should be accompanied by a comment detailing its...
96
+ - ** Usage of ` unsafe ` is heavily discouraged** . If ` unsafe ` is required, it
97
+ should be accompanied by a comment detailing its...
98
+
92
99
- Justification, potentially including quantifiable reasons why safe
93
100
alternatives were not used (e.g. via a benchmark showing a valuable[ ^ 1 ]
94
101
performance improvements).
95
- - Safety, as per [ ` clippy::undocumented_unsafe_blocks ` ] ( https://rust-lang.github.io/rust-clippy/master/#undocumented_unsafe_blocks ) .
96
- This comment must list all invariants of the called function, and
97
- explain why there are upheld. If relevant, it must also prove that
102
+ - Safety, as per
103
+ [ ` clippy::undocumented_unsafe_blocks ` ] ( https://rust-lang.github.io/rust-clippy/master/#undocumented_unsafe_blocks ) .
104
+ This comment must list all invariants of the called function, and explain
105
+ why there are upheld. If relevant, it must also prove that
98
106
[ undefined behavior] ( https://doc.rust-lang.org/reference/behavior-considered-undefined.html )
99
107
is not possible.
100
108
101
- [ ^ 1 ] : Performance improvements in non-hot paths are unlikely to be considered valuable.
102
-
103
109
E.g.
104
110
105
111
``` rust
@@ -113,24 +119,26 @@ Your contribution needs to meet the following standards:
113
119
}
114
120
```
115
121
116
- - Document your pull requests. Include the reasoning behind each change, and
117
- the testing done.
122
+ - Document your pull requests. Include the reasoning behind each change, and the
123
+ testing done.
124
+
118
125
- Acknowledge Firecracker's [ Apache 2.0 license] ( LICENSE ) and certify that no
119
126
part of your contribution contravenes this license by signing off on all your
120
127
commits with ` git -s ` . Ensure that every file in your pull request has a
121
128
header referring to the repository license file.
122
129
123
130
## Developer Certificate of Origin
124
131
125
- Firecracker is an open source product released under the [ Apache 2.0 license] ( LICENSE ) .
132
+ Firecracker is an open source product released under the
133
+ [ Apache 2.0 license] ( LICENSE ) .
126
134
127
135
We respect intellectual property rights of others and we want to make sure all
128
- incoming contributions are correctly attributed and licensed.
129
- A Developer Certificate of Origin (DCO) is a lightweight mechanism to do that.
136
+ incoming contributions are correctly attributed and licensed. A Developer
137
+ Certificate of Origin (DCO) is a lightweight mechanism to do that.
130
138
131
- The DCO is a declaration attached to every contribution made by every
132
- developer. In the commit message of the contribution, the developer simply adds
133
- a ` Signed-off-by ` statement and thereby agrees to the DCO, which you can find
139
+ The DCO is a declaration attached to every contribution made by every developer.
140
+ In the commit message of the contribution, the developer simply adds a
141
+ ` Signed-off-by ` statement and thereby agrees to the DCO, which you can find
134
142
below or at DeveloperCertificate.org (< http://developercertificate.org/ > ).
135
143
136
144
```
@@ -167,16 +175,19 @@ Certificate of Origin. DCO checks are enabled via <https://github.com/apps/dco>,
167
175
and your PR will fail CI without it.
168
176
169
177
Additionally, we kindly ask you to use your real name. We do not accept
170
- anonymous contributors, nor those utilizing pseudonyms.
171
- Each commit must include a DCO which looks like this:
178
+ anonymous contributors, nor those utilizing pseudonyms. Each commit must include
179
+ a DCO which looks like this:
172
180
173
181
```
174
182
Signed-off-by: Jane Smith <[email protected] >
175
183
```
176
184
177
- You may type this line on your own when writing your commit messages.
178
- However, if your ` user.name ` and ` user.email ` are set in your git config,
179
- you can use ` -s ` or ` --signoff ` to add the ` Signed-off-by ` line to the end of
180
- the commit message automatically.
185
+ You may type this line on your own when writing your commit messages. However,
186
+ if your ` user.name ` and ` user.email ` are set in your git config, you can use
187
+ ` -s ` or ` --signoff ` to add the ` Signed-off-by ` line to the end of the commit
188
+ message automatically.
181
189
182
190
Forgot to add DCO to a commit? Amend it with ` git commit --amend -s ` .
191
+
192
+ [ ^ 1 ] : Performance improvements in non-hot paths are unlikely to be considered
193
+ valuable.
0 commit comments