Skip to content

[Tests] Periodically run Firecracker integration tests under sanitizers #1662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
raduiliescu opened this issue Mar 9, 2020 · 3 comments
Open
Labels
Status: Parked Indicates that an issues or pull request will be revisited later Type: Enhancement Indicates new feature requests

Comments

@raduiliescu
Copy link
Contributor

No description provided.

@acatangiu
Copy link
Contributor

This is now unblocked after merging #2599

@dianpopa
Copy link
Contributor

Also addresses #119

@JonathanWoollett-Light JonathanWoollett-Light added Type: Enhancement Indicates new feature requests and removed Quality: Improvement labels Mar 24, 2023
@roypat roypat added the Status: Parked Indicates that an issues or pull request will be revisited later label Mar 4, 2024
@roypat
Copy link
Contributor

roypat commented Mar 4, 2024

I'm marking this as parked, as generally, being able to detect memory leaks and undefined behavior in our integration tests would be nice to have, albeit significantly less relevant due to Rust's strong memory safety guarantees (and for those parts of the codebase we have covered with kani harnesses, we get these guarantees from kani). Furthermore, Valgrind does not seem to play nicely with Rust code, as rustc's LLVM backend on x86_64 uses a lot of instructions which valgrind does not support (for example, the SIP hasher used by default in Rust's HashMap and HashSet uses hardware acceleration not supported by valgrind).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Parked Indicates that an issues or pull request will be revisited later Type: Enhancement Indicates new feature requests
Projects
None yet
Development

No branches or pull requests

5 participants