runtime: make BPF Loader v3 structs zero-alloc

Removes dynamic allocations in BPF Loader v3 by turning pointer
option types into flat option types.

Author: riptl

src/flamenco/runtime/fd_runtime.c

@@ -2365,8 +2365,8 @@ fd_new_target_program_data_account( fd_exec_slot_ctx_t * slot_ctx,
 
   /* https://github.com/anza-xyz/agave/blob/v2.1.0/runtime/src/bank/builtins/core_bpf_migration/mod.rs#L118-L125 */
   if( config_upgrade_authority_address!=NULL ) {
-    if( FD_UNLIKELY( state->inner.buffer.authority_address==NULL ||
-                     memcmp( config_upgrade_authority_address, state->inner.buffer.authority_address, sizeof(fd_pubkey_t) ) ) ) {
+    if( FD_UNLIKELY( !state->inner.buffer.has_authority_address ||
+                     !fd_pubkey_eq( config_upgrade_authority_address, &state->inner.buffer.authority_address ) ) ) {
       return -1;
     }
   }
@@ -2386,11 +2386,13 @@ fd_new_target_program_data_account( fd_exec_slot_ctx_t * slot_ctx,
     .discriminant = fd_bpf_upgradeable_loader_state_enum_program_data,
     .inner = {
       .program_data = {
-        .slot = slot_ctx->slot_bank.slot,
-        .upgrade_authority_address = config_upgrade_authority_address
+        .slot = slot_ctx->slot_bank.slot
       }
     }
   };
+  fd_types_option_flat_from_nullable(
+      programdata_metadata.inner.program_data, upgrade_authority_address,
+      config_upgrade_authority_address );
 
   /* https://github.com/anza-xyz/agave/blob/v2.1.0/runtime/src/bank/builtins/core_bpf_migration/mod.rs#L139-L144 */
   new_target_program_data_account->vt->set_lamports( new_target_program_data_account, lamports );

src/flamenco/runtime/program/fd_bpf_loader_program.c

@@ -82,17 +82,17 @@ static int
 fd_bpf_get_executable_program_content_for_upgradeable_loader( fd_exec_slot_ctx_t *    slot_ctx,
                                                               fd_txn_account_t *      program_acc,
                                                               uchar const **          program_data,
-                                                              ulong *                 program_data_len,
-                                                              fd_spad_t *             runtime_spad ) {
+                                                              ulong *                 program_data_len ) {
   FD_TXN_ACCOUNT_DECL( programdata_acc );
 
-  fd_bpf_upgradeable_loader_state_t * program_account_state =
-    fd_bincode_decode_spad(
-      bpf_upgradeable_loader_state, runtime_spad,
+  fd_bpf_upgradeable_loader_state_t program_account_state[1];
+  if( FD_UNLIKELY( !fd_bincode_decode_flat(
+      program_account_state,
+      bpf_upgradeable_loader_state,
       program_acc->vt->get_data( program_acc ),
       program_acc->vt->get_data_len( program_acc ),
-      NULL );
-  if( FD_UNLIKELY( !program_account_state ) ) {
+      NULL
+  ) ) ) {
     return -1;
   }
   if( !fd_bpf_upgradeable_loader_state_is_program( program_account_state ) ) {
@@ -182,7 +182,7 @@ fd_bpf_create_bpf_program_cache_entry( fd_exec_slot_ctx_t *    slot_ctx,
 
     int res;
     if( !memcmp( program_acc->vt->get_owner( program_acc ), fd_solana_bpf_loader_upgradeable_program_id.key, sizeof(fd_pubkey_t) ) ) {
-      res = fd_bpf_get_executable_program_content_for_upgradeable_loader( slot_ctx, program_acc, &program_data, &program_data_len, runtime_spad );
+      res = fd_bpf_get_executable_program_content_for_upgradeable_loader( slot_ctx, program_acc, &program_data, &program_data_len );
     } else if( !memcmp( program_acc->vt->get_owner( program_acc ), fd_solana_bpf_loader_v4_program_id.key, sizeof(fd_pubkey_t) ) ) {
       res = fd_bpf_get_executable_program_content_for_v4_loader( program_acc, &program_data, &program_data_len );
     } else {

src/flamenco/runtime/program/fd_bpf_program_util.c

@@ -3,9 +3,6 @@
 
 #include "../../fd_flamenco_base.h"
 #include "../../runtime/fd_system_ids.h"
-#include "../../features/fd_features.h"
-#include "../context/fd_exec_epoch_ctx.h"
-#include "../context/fd_exec_slot_ctx.h"
 #include "../fd_system_ids.h"
 #include "../fd_system_ids_pp.h"
 

src/flamenco/runtime/program/fd_builtin_programs.h

@@ -2748,15 +2748,9 @@ void *fd_bpf_upgradeable_loader_state_buffer_generate( void *mem, void **alloc_m
   *alloc_mem = (uchar *) *alloc_mem + sizeof(fd_bpf_upgradeable_loader_state_buffer_t);
   fd_bpf_upgradeable_loader_state_buffer_new(mem);
   {
-    uchar is_null = fd_rng_uchar( rng ) % 2;
-    if( !is_null ) {
-      self->authority_address = (fd_pubkey_t *) *alloc_mem;
-      *alloc_mem = (uchar *) *alloc_mem + sizeof(fd_pubkey_t);
-      fd_pubkey_new( self->authority_address );
-      fd_pubkey_generate( self->authority_address, alloc_mem, rng );
-    }
-    else {
-    self->authority_address = NULL;
+    self->has_authority_address = fd_rng_uchar( rng ) % 2;
+    if( self->has_authority_address ) {
+      fd_pubkey_generate( &self->authority_address, alloc_mem, rng );
     }
   }
   return mem;
@@ -2776,15 +2770,9 @@ void *fd_bpf_upgradeable_loader_state_program_data_generate( void *mem, void **a
   fd_bpf_upgradeable_loader_state_program_data_new(mem);
   self->slot = fd_rng_ulong( rng );
   {
-    uchar is_null = fd_rng_uchar( rng ) % 2;
-    if( !is_null ) {
-      self->upgrade_authority_address = (fd_pubkey_t *) *alloc_mem;
-      *alloc_mem = (uchar *) *alloc_mem + sizeof(fd_pubkey_t);
-      fd_pubkey_new( self->upgrade_authority_address );
-      fd_pubkey_generate( self->upgrade_authority_address, alloc_mem, rng );
-    }
-    else {
-    self->upgrade_authority_address = NULL;
+    self->has_upgrade_authority_address = fd_rng_uchar( rng ) % 2;
+    if( self->has_upgrade_authority_address ) {
+      fd_pubkey_generate( &self->upgrade_authority_address, alloc_mem, rng );
     }
   }
   return mem;

src/flamenco/types/fd_fuzz_types.h

@@ -1785,7 +1785,7 @@
       "name": "bpf_upgradeable_loader_state_buffer",
       "type": "struct",
       "fields": [
-        { "name": "authority_address", "type": "option", "element": "pubkey" }
+        { "name": "authority_address", "type": "option", "element": "pubkey", "flat": true }
       ]
     },
     {
@@ -1800,7 +1800,7 @@
       "type": "struct",
       "fields": [
         { "name": "slot", "type": "ulong" },
-        { "name": "upgrade_authority_address", "type": "option", "element": "pubkey" }
+        { "name": "upgrade_authority_address", "type": "option", "element": "pubkey", "flat": true }
       ]
     },
     {