Skip to content

Commit 635b95e

Browse files
pbrubeckconnorjward
andcommitted
Apply suggestions from code review
Co-authored-by: Connor Ward <[email protected]>
1 parent cefb398 commit 635b95e

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

firedrake/mesh.py

-1
Original file line numberDiff line numberDiff line change
@@ -2416,7 +2416,6 @@ def cell_sizes(self):
24162416
else:
24172417
mesh = self
24182418

2419-
# Project the CellSize into P1
24202419
P1 = FunctionSpace(mesh, "Lagrange", 1)
24212420
h = project(CellSize(mesh), P1)
24222421

tests/firedrake/regression/test_interpolate_zany.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -110,16 +110,16 @@ def test_interpolate_zany_into_vom(V, mesh, which, vom):
110110

111111
# Construct a Cofunction on P0(vom)*
112112
Fvom = Cofunction(P0.dual()).assign(1)
113-
expected = assemble(action(Fvom, expected))
113+
expected_action = assemble(action(Fvom, expected))
114114

115115
# Interpolate a Function into Fvom
116116
f_at_vom = assemble(Interpolate(fexpr, Fvom))
117-
assert numpy.allclose(f_at_vom, expected)
117+
assert numpy.allclose(f_at_vom, expected_action)
118118

119119
# Interpolate a TestFunction into Fvom
120120
expr_vom = assemble(Interpolate(vexpr, Fvom))
121121
f_at_vom = assemble(action(expr_vom, f))
122-
assert numpy.allclose(f_at_vom, expected)
122+
assert numpy.allclose(f_at_vom, expected_action)
123123

124124

125125
def test_high_order_mesh_cell_sizes():

0 commit comments

Comments
 (0)