Skip to content

Having different versions of generic-array breaks the build #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
golddranks opened this issue Sep 13, 2017 · 5 comments
Closed

Having different versions of generic-array breaks the build #49

golddranks opened this issue Sep 13, 2017 · 5 comments

Comments

@golddranks
Copy link

Lately, there has been some breakages when crates that depend on different versions (0.7 and 0.8) of generic-array are being used in the same build. The breakage is due to cargo update not finding compatible crates. See rust-lang/cargo#4474 It's unclear to me whether the build would actually break, because it fails already when cargo update is being performed.

See also durch/rust-s3#18 and sfackler/rust-postgres#290

An example of the breaking which I'm familiar with is rust-s3 and postgres. However, these crates are fully independent and don't interact. They don't even expose any generic-array types in their API, as far as I know.

Do you know as the author of this crate any reason why different versions of this crate would break the build?

@sfackler
Copy link

This is due to this dependency constraint in 0.7: https://github.com/fizyk20/generic-array/blob/0.7.2/Cargo.toml#L15, which isn't compatible with other semver compatible versions of typenum. Cargo will refuse to have copies of both typenum 1.5 and 1.7 in the crate graph at the same time.

@fizyk20
Copy link
Owner

fizyk20 commented Sep 13, 2017

Oh right, that was silly. Do you have any idea if it's possible to publish 0.7.3 even after 0.8 has been published? If yes, then I could fix that constraint and crates depending on 0.7 would probably be fixed.

@sfackler
Copy link

Yep it should work fine - there aren't any restrictions on publishing things "out of order".

@fizyk20
Copy link
Owner

fizyk20 commented Sep 13, 2017

Awesome - I just published 0.7.3 which should fix this problem. I'll close this issue after you confirm that it is indeed fixed :)

@fizyk20
Copy link
Owner

fizyk20 commented Oct 21, 2017

Looks like it's fixed, so I'm closing this.

@fizyk20 fizyk20 closed this as completed Oct 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants